You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/09/23 00:04:44 UTC
[jira] Created: (HADOOP-4244) In "ant test-patch",
runContribTestOnEclipseFiles should not be run on Hudson only
In "ant test-patch", runContribTestOnEclipseFiles should not be run on Hudson only
----------------------------------------------------------------------------------
Key: HADOOP-4244
URL: https://issues.apache.org/jira/browse/HADOOP-4244
Project: Hadoop Core
Issue Type: Improvement
Components: build, test
Reporter: Tsz Wo (Nicholas), SZE
runContribTestOnEclipseFiles is ONLY executed on Hudson but it won't be executed by default. So it won't be run when developers run "ant test-patch".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4244) In "ant test-patch",
runContribTestOnEclipseFiles should not be run on Hudson only
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633863#action_12633863 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4244:
------------------------------------------------
I created HADOOP-4249 and submitted a patch for adding hsqldb.jar in the eclipse templates. How can I test it locally?
> In "ant test-patch", runContribTestOnEclipseFiles should not be run on Hudson only
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-4244
> URL: https://issues.apache.org/jira/browse/HADOOP-4244
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build, test
> Reporter: Tsz Wo (Nicholas), SZE
>
> runContribTestOnEclipseFiles is ONLY executed on Hudson but it won't be executed by default. So it won't be run when developers run "ant test-patch".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-4244) In "ant test-patch",
runContribTestOnEclipseFiles should not be run on Hudson only
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE resolved HADOOP-4244.
--------------------------------------------
Resolution: Fixed
Fix Version/s: 0.20.0
Hadoop Flags: [Reviewed]
Thanks Nigel for reviewing.
I just committed this.
> In "ant test-patch", runContribTestOnEclipseFiles should not be run on Hudson only
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-4244
> URL: https://issues.apache.org/jira/browse/HADOOP-4244
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build, test
> Reporter: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.0
>
> Attachments: 4244_20080924.patch, 4244_20080924b.patch
>
>
> runContribTestOnEclipseFiles is ONLY executed on Hudson but it won't be executed by default. So it won't be run when developers run "ant test-patch".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4244) In "ant test-patch",
runContribTestOnEclipseFiles should not be run on Hudson only
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4244:
-------------------------------------------
Assignee: Tsz Wo (Nicholas), SZE
> In "ant test-patch", runContribTestOnEclipseFiles should not be run on Hudson only
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-4244
> URL: https://issues.apache.org/jira/browse/HADOOP-4244
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build, test
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.0
>
> Attachments: 4244_20080924.patch, 4244_20080924b.patch
>
>
> runContribTestOnEclipseFiles is ONLY executed on Hudson but it won't be executed by default. So it won't be run when developers run "ant test-patch".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4244) In "ant test-patch",
runContribTestOnEclipseFiles should not be run on Hudson only
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633817#action_12633817 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4244:
------------------------------------------------
There are probably bugs in runContribTests(). It gives a -1 even if there is no tests fails. For example,
see https://issues.apache.org/jira/browse/HADOOP-4242?focusedCommentId=12633545#action_12633545
> In "ant test-patch", runContribTestOnEclipseFiles should not be run on Hudson only
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-4244
> URL: https://issues.apache.org/jira/browse/HADOOP-4244
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build, test
> Reporter: Tsz Wo (Nicholas), SZE
>
> runContribTestOnEclipseFiles is ONLY executed on Hudson but it won't be executed by default. So it won't be run when developers run "ant test-patch".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4244) In "ant test-patch",
runContribTestOnEclipseFiles should not be run on Hudson only
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634930#action_12634930 ]
Hudson commented on HADOOP-4244:
--------------------------------
Integrated in Hadoop-trunk #615 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/615/])
> In "ant test-patch", runContribTestOnEclipseFiles should not be run on Hudson only
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-4244
> URL: https://issues.apache.org/jira/browse/HADOOP-4244
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build, test
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.0
>
> Attachments: 4244_20080924.patch, 4244_20080924b.patch
>
>
> runContribTestOnEclipseFiles is ONLY executed on Hudson but it won't be executed by default. So it won't be run when developers run "ant test-patch".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4244) In "ant test-patch",
runContribTestOnEclipseFiles should not be run on Hudson only
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4244:
-------------------------------------------
Attachment: 4244_20080924b.patch
4244_20080924b.patch: updated the messages
> In "ant test-patch", runContribTestOnEclipseFiles should not be run on Hudson only
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-4244
> URL: https://issues.apache.org/jira/browse/HADOOP-4244
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build, test
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: 4244_20080924.patch, 4244_20080924b.patch
>
>
> runContribTestOnEclipseFiles is ONLY executed on Hudson but it won't be executed by default. So it won't be run when developers run "ant test-patch".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4244) In "ant test-patch",
runContribTestOnEclipseFiles should not be run on Hudson only
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4244:
-------------------------------------------
Attachment: 4244_20080924.patch
4244_20080924.patch: separate eclipse tests and contrib tests
> In "ant test-patch", runContribTestOnEclipseFiles should not be run on Hudson only
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-4244
> URL: https://issues.apache.org/jira/browse/HADOOP-4244
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build, test
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: 4244_20080924.patch
>
>
> runContribTestOnEclipseFiles is ONLY executed on Hudson but it won't be executed by default. So it won't be run when developers run "ant test-patch".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4244) In "ant test-patch",
runContribTestOnEclipseFiles should not be run on Hudson only
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634240#action_12634240 ]
Nigel Daley commented on HADOOP-4244:
-------------------------------------
Patch review:
"Running Eclipse tests." ->
"Running Eclipse classpath verification."
"-1 Eclipse tests. The patch failed Eclipse unit tests." ->
"+1 Eclipse classpath. The patch causes the Eclipse classpath to differ from the contents of the lib directory."
"+1 Eclipse tests. The patch passed Eclipse unit tests." ->
"+1 Eclipse tests. The patch retains Eclipse classpath integrity."
> In "ant test-patch", runContribTestOnEclipseFiles should not be run on Hudson only
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-4244
> URL: https://issues.apache.org/jira/browse/HADOOP-4244
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build, test
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: 4244_20080924.patch
>
>
> runContribTestOnEclipseFiles is ONLY executed on Hudson but it won't be executed by default. So it won't be run when developers run "ant test-patch".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4244) In "ant test-patch",
runContribTestOnEclipseFiles should not be run on Hudson only
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-4244:
--------------------------------
Nicholas, the -1 comes from the eclipse plugin classpath check that someone put into test-patch. At the end of the build, you can see:
{quote}
[exec] FAILED. Some jars are not declared in the Eclipse project.
[exec] Declared jars: lib/clover.jar
[exec] lib/commons-cli-2.0-SNAPSHOT.jar
[exec] lib/commons-codec-1.3.jar
[exec] lib/commons-httpclient-3.0.1.jar
[exec] lib/commons-logging-1.0.4.jar
[exec] lib/commons-logging-api-1.0.4.jar
[exec] lib/commons-net-1.4.1.jar
[exec] lib/excluded/checkstyle-all-4.3.jar
[exec] lib/jets3t-0.6.1.jar
[exec] lib/jetty-5.1.4.jar
[exec] lib/jetty-ext/commons-el.jar
[exec] lib/jetty-ext/jasper-compiler.jar
[exec] lib/jetty-ext/jasper-runtime.jar
[exec] lib/jetty-ext/jsp-api.jar
[exec] lib/junit-3.8.1.jar
[exec] lib/kfs-0.2.0.jar
[exec] lib/log4j-1.2.15.jar
[exec] lib/oro-2.0.8.jar
[exec] lib/servlet-api.jar
[exec] lib/slf4j-api-1.4.3.jar
[exec] lib/slf4j-log4j12-1.4.3.jar
[exec] lib/xmlenc-0.52.jar
[exec] src/test/lib/ftplet-api-1.0.0-SNAPSHOT.jar
[exec] src/test/lib/ftpserver-core-1.0.0-SNAPSHOT.jar
[exec] src/test/lib/ftpserver-server-1.0.0-SNAPSHOT.jar
[exec] src/test/lib/mina-core-2.0.0-M2-20080407.124109-12.jar
[exec] Present jars: lib/clover.jar
[exec] lib/commons-cli-2.0-SNAPSHOT.jar
[exec] lib/commons-codec-1.3.jar
[exec] lib/commons-httpclient-3.0.1.jar
[exec] lib/commons-logging-1.0.4.jar
[exec] lib/commons-logging-api-1.0.4.jar
[exec] lib/commons-net-1.4.1.jar
[exec] lib/excluded/checkstyle-all-4.3.jar
[exec] lib/hsqldb.jar
[exec] lib/jets3t-0.6.1.jar
[exec] lib/jetty-5.1.4.jar
[exec] lib/jetty-ext/commons-el.jar
[exec] lib/jetty-ext/jasper-compiler.jar
[exec] lib/jetty-ext/jasper-runtime.jar
[exec] lib/jetty-ext/jsp-api.jar
[exec] lib/junit-3.8.1.jar
[exec] lib/kfs-0.2.0.jar
[exec] lib/log4j-1.2.15.jar
[exec] lib/oro-2.0.8.jar
[exec] lib/servlet-api.jar
[exec] lib/slf4j-api-1.4.3.jar
[exec] lib/slf4j-log4j12-1.4.3.jar
[exec] lib/xmlenc-0.52.jar
[exec] src/test/lib/ftplet-api-1.0.0-SNAPSHOT.jar
[exec] src/test/lib/ftpserver-core-1.0.0-SNAPSHOT.jar
[exec] src/test/lib/ftpserver-server-1.0.0-SNAPSHOT.jar
[exec] src/test/lib/mina-core-2.0.0-M2-20080407.124109-12.jar
{quote}
> In "ant test-patch", runContribTestOnEclipseFiles should not be run on Hudson only
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-4244
> URL: https://issues.apache.org/jira/browse/HADOOP-4244
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build, test
> Reporter: Tsz Wo (Nicholas), SZE
>
> runContribTestOnEclipseFiles is ONLY executed on Hudson but it won't be executed by default. So it won't be run when developers run "ant test-patch".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4244) In "ant test-patch",
runContribTestOnEclipseFiles should not be run on Hudson only
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634270#action_12634270 ]
Nigel Daley commented on HADOOP-4244:
-------------------------------------
+1. Please commit WITHOUT marking Patch Available. This patch can't be tested properly by Hudson since it modifies the script that Hudson runs.
> In "ant test-patch", runContribTestOnEclipseFiles should not be run on Hudson only
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-4244
> URL: https://issues.apache.org/jira/browse/HADOOP-4244
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build, test
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: 4244_20080924.patch, 4244_20080924b.patch
>
>
> runContribTestOnEclipseFiles is ONLY executed on Hudson but it won't be executed by default. So it won't be run when developers run "ant test-patch".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4244) In "ant test-patch",
runContribTestOnEclipseFiles should not be run on Hudson only
Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634023#action_12634023 ]
Vinod K V commented on HADOOP-4244:
-----------------------------------
I remember that a similar problem occurred a while ago too. It could have been much easier to spot this had Hudson explicitly pointed out the jars that were missing/extra, saving us from iterating through the whole list of jars and finding out the culprit.
> In "ant test-patch", runContribTestOnEclipseFiles should not be run on Hudson only
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-4244
> URL: https://issues.apache.org/jira/browse/HADOOP-4244
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build, test
> Reporter: Tsz Wo (Nicholas), SZE
>
> runContribTestOnEclipseFiles is ONLY executed on Hudson but it won't be executed by default. So it won't be run when developers run "ant test-patch".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.