You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/10 16:22:41 UTC
[GitHub] [airflow] dstandish opened a new pull request, #25648: WIP - TP's fixes for `schedule` param unification
dstandish opened a new pull request, #25648:
URL: https://github.com/apache/airflow/pull/25648
splitting out to other PR so as not to block main one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #25648: More DAG(schedule=...) improvements
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #25648:
URL: https://github.com/apache/airflow/pull/25648#discussion_r946691752
##########
tests/system/providers/amazon/aws/example_emr_serverless.py:
##########
@@ -40,7 +40,6 @@
with DAG(
dag_id=DAG_ID,
- schedule_interval='@once',
Review Comment:
Hmm this one is actually inherited from @dstandish’s previous PR (there are several more changes like this there). I’m assuming yes it changes the schedule but it doesn’t really matter since this is only an example anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25648: More DAG(schedule=...) improvements
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25648:
URL: https://github.com/apache/airflow/pull/25648#issuecomment-1221626774
I think it needs rebase/removing conflicts after the related changes were merged :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #25648: More DAG(schedule=...) improvements
Posted by GitBox <gi...@apache.org>.
uranusjr merged PR #25648:
URL: https://github.com/apache/airflow/pull/25648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #25648: More DAG(schedule=...) improvements
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #25648:
URL: https://github.com/apache/airflow/pull/25648#discussion_r946589895
##########
tests/system/providers/amazon/aws/example_emr_serverless.py:
##########
@@ -40,7 +40,6 @@
with DAG(
dag_id=DAG_ID,
- schedule_interval='@once',
Review Comment:
By removing this doesn't it change the default to `@daily`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org