[GitHub] [flink] zhuzhurk commented on a change in pull request #9791: [FLINK-14248][runtime] Let LazyFromSourcesSchedulingStrategy restart terminated tasks

[GitBox <gi...@apache.org>]

zhuzhurk commented on a change in pull request #9791: [FLINK-14248][runtime] Let LazyFromSourcesSchedulingStrategy restart terminated tasks
URL: https://github.com/apache/flink/pull/9791#discussion_r329607855
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/LazyFromSourcesSchedulingStrategy.java
 ##########
 @@ -102,11 +108,12 @@ public void onExecutionStateChange(ExecutionVertexID executionVertexId, Executio
 		final Set<SchedulingExecutionVertex> verticesToSchedule = schedulingTopology.getVertexOrThrow(executionVertexId)
 			.getProducedResultPartitions()
 			.stream()
+			.filter(partition -> partition.getPartitionType() == ResultPartitionType.BLOCKING)
 
 Review comment:
   Yes. 
   
   Here's some more details:
   Technically this is a bug because it may schedule a task that is already scheduled in `onPartitionConsumable`.
   However, it's not problematic at the moment because scheduling of a non-CREATED vertex will be filtered out with `IS_IN_CREATED_EXECUTION_STATE`.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services