You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cayenne.apache.org by "Jean T. Anderson" <jt...@bristowhill.com> on 2006/09/19 04:38:16 UTC
[REVIEW] Cayenne 2.0.1-incubating release
I don't want to get in the way of the VOTE itself, so I thought I'd
start a separate thread for review comments.
Andrus Adamchik wrote:
...
> * release files: http://people.apache.org/~aadamchik/release/2.0.1/
> * release 2.0.1 is a full ASF-compliant equivalent of a non-ASF Cayenne
> 1.2.1.
> * the release has no known IP issues
> * the release has no (L)GPL or other incompatible license dependencies
> * the release is compliant with Apache guidelines (NOTICE, DISCLAIMER,
> LICENSE files placement, "incubating" in the naming).
>
> Would be great to catch any inconsistencies now, before we send it out
> for the Incubator PMC vote.
There's a handy licensing tool here (derby just used this for the recent
license updating, which is how I found out about it):
https://svn.apache.org/repos/private/committers/relicense/src/perl/insert_license.pl
If you run it in practice mode (-p) it doesn't actually do anything but
provides a report of what needs to be done; e.g. here's what I just did:
insert_license.pl -p /opt/Apache/cayenne-2.0.1-incubating/src >&
cayenne.log
Here's the summary at the end of that cayenne.log output:
Total 1080 text files were investigated.
New licenses would be inserted in 40 files.
Skipped 1027 files with an existing license:
(Apache v2.0=0, v2.0a=0, v2.0b=1025)
(Apache v1.2=0, v1.1=0, v1.0=0)
(Other=1, PublicDomain=1)
Skipped 1 XML files with missing XML Declaration.
Ignored 2 files of specified type (.dcl .ent .pen .properties .ant
.tmpl NoExtension)
Skipped 11 files of unknown type.
WARNING: 5 files had another license as well as the new
Apache v2.0 license. (Scan the log output for lines with "WARN: dual".)
List of unknown filename extensions and ignored filename extensions:
(Add new fileTypes to this script if you want them to be catered for.)
.classpath=3 .jjt=1 .log=1 .prefs=4 .project=3 .properties=5 .vm=8
List of all unique filename extensions:
.classpath=3 .html=35 .java=986 .jj=1 .jjt=1 .jsp=4 .log=1 .prefs=4
.project=3 .properties=5 .txt=2 .vm=8 .xml=27
Finished practice run.
I'm attaching the complete "cayenne.log" report just in case any of the
"New licenses would be inserted in 40 files." and "WARNING: 5 files had
another license as well as the new" reports amount to anything.
regards,
-jean
Re: [REVIEW] Cayenne 2.0.1-incubating release
Posted by Jim Jagielski <ji...@jaguNET.com>.
+1
On Sep 18, 2006, at 11:54 PM, Jean T. Anderson wrote:
> Andrus Adamchik wrote:
>>
>> On Sep 18, 2006, at 11:06 PM, Andrus Adamchik wrote:
>>
>>> I guess we should fix them on trunk and 2.0 branch to avoid further
>>> warnings, but I guess it
>>
>> oops, didn't finish the phrase. What I meant to say is that I
>> don't see
>> it as a show stopper for the release, but I guess we can post
>> another
>> snapshot in a day or two when others had a chance to do the
>> review and
>> post their comments... or we may not, if no other problems are
>> found (?)
>
> I'd definitely give it a few days and address all comments.
>
> I notice that recent incubator releases have the md5 sigs
> (http://people.apache.org/dist/incubator/tuscany/incubating-M1/ ,
> http://people.apache.org/dist/incubator/stdcxx/releases/ ,
> http://people.apache.org/dist/incubator/harmony/snapshots/ ) so that
> might be another thing to look into (more info is at
> http://www.apache.org/dev/release-signing.html).
>
> -jean
>
Re: [REVIEW] Cayenne 2.0.1-incubating release
Posted by "Jean T. Anderson" <jt...@bristowhill.com>.
Andrus Adamchik wrote:
>
> On Sep 18, 2006, at 11:06 PM, Andrus Adamchik wrote:
>
>> I guess we should fix them on trunk and 2.0 branch to avoid further
>> warnings, but I guess it
>
> oops, didn't finish the phrase. What I meant to say is that I don't see
> it as a show stopper for the release, but I guess we can post another
> snapshot in a day or two when others had a chance to do the review and
> post their comments... or we may not, if no other problems are found (?)
I'd definitely give it a few days and address all comments.
I notice that recent incubator releases have the md5 sigs
(http://people.apache.org/dist/incubator/tuscany/incubating-M1/ ,
http://people.apache.org/dist/incubator/stdcxx/releases/ ,
http://people.apache.org/dist/incubator/harmony/snapshots/ ) so that
might be another thing to look into (more info is at
http://www.apache.org/dev/release-signing.html).
-jean
Re: [REVIEW] Cayenne 2.0.1-incubating release
Posted by Andrus Adamchik <an...@objectstyle.org>.
On Sep 18, 2006, at 11:06 PM, Andrus Adamchik wrote:
> I guess we should fix them on trunk and 2.0 branch to avoid further
> warnings, but I guess it
oops, didn't finish the phrase. What I meant to say is that I don't
see it as a show stopper for the release, but I guess we can post
another snapshot in a day or two when others had a chance to do the
review and post their comments... or we may not, if no other problems
are found (?)
Andrus
Re: [REVIEW] Cayenne 2.0.1-incubating release
Posted by "Jean T. Anderson" <jt...@bristowhill.com>.
Andrus Adamchik wrote:
> I grep'd the previous message for WARN, I think it is false positives.
> E.g.: DomainDisplayEvent, that has package name preceding the license:
>
> package org.apache.cayenne.modeler.event;
> /*****************************************************************
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> * distributed with this work for additional information...
>
> I guess we should fix them on trunk and 2.0 branch to avoid further
> warnings, but I guess it
the tool isn't savvy enough. That's ok -- it's just a tool to hopefully
catch anything that was missed.
> Re: "Insert new license" message - those are the files generated by the
> tools used in the examples (such as UntitledDomainNode.driver.xml). I
> think we discussed before that those do not require licensing headers.
oh that's right! I do remember now.
-jean
Re: [REVIEW] Cayenne 2.0.1-incubating release
Posted by Andrus Adamchik <an...@objectstyle.org>.
I grep'd the previous message for WARN, I think it is false
positives. E.g.: DomainDisplayEvent, that has package name preceding
the license:
package org.apache.cayenne.modeler.event;
/*****************************************************************
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information...
I guess we should fix them on trunk and 2.0 branch to avoid further
warnings, but I guess it
Re: "Insert new license" message - those are the files generated by
the tools used in the examples (such as
UntitledDomainNode.driver.xml). I think we discussed before that
those do not require licensing headers.
Andrus
On Sep 18, 2006, at 10:41 PM, Jean T. Anderson wrote:
> Jean T. Anderson wrote:
> ...
>> I'm attaching the complete "cayenne.log" report just in case any
>> of the
>> "New licenses would be inserted in 40 files." and "WARNING: 5
>> files had
>> another license as well as the new" reports amount to anything.
> ...
> ouch! I didn't look first to see how big that file was -- my
> apologies!
> It's not clear to me that the entire file actually got posted to the
> list. If anybody wants it, let me know and I'll forward it to you.
>
> -jean
>
Re: [REVIEW] Cayenne 2.0.1-incubating release
Posted by "Jean T. Anderson" <jt...@bristowhill.com>.
Jean T. Anderson wrote:
...
> I'm attaching the complete "cayenne.log" report just in case any of the
> "New licenses would be inserted in 40 files." and "WARNING: 5 files had
> another license as well as the new" reports amount to anything.
...
ouch! I didn't look first to see how big that file was -- my apologies!
It's not clear to me that the entire file actually got posted to the
list. If anybody wants it, let me know and I'll forward it to you.
-jean
Re: [REVIEW] Cayenne 2.0.1-incubating release
Posted by "Jean T. Anderson" <jt...@bristowhill.com>.
Andrus Adamchik wrote:
> On Sep 18, 2006, at 10:38 PM, Jean T. Anderson wrote:
...
>> I notice that recent incubator releases have the md5 sigs
>> (http://people.apache.org/dist/incubator/tuscany/incubating-M1/ ,
>> http://people.apache.org/dist/incubator/stdcxx/releases/ ,
>> http://people.apache.org/dist/incubator/harmony/snapshots/ ) so that
>> might be another thing to look into (more info is at
>> http://www.apache.org/dev/release-signing.html)
>
> When we finish the review, I'll post the new release with the
> signatures. Although my PGP key is not known to anybody, defeating the
> purpose of signing. So I guess we can limit this to just MD5's.
I'd encourage you to go ahead and sign it anyhow (and upload your public
key to people.apache.org).
http://www.apache.org/dev/new-committers-guide.html#pgp points to
henkp's page. He has a fascinating link to the apache web of trust. It
looks to me like some other committers who have signed releases also
don't have their key signed by anyone in the apache web. At any rate,
don't let that stop you from signing it.
If any cayenne committers will be at ApacheCon in Austin next month, be
sure to attend the key signing -- it's usually the evening of the first
day of the conference.
This is getting a little off topic, but has cayenne set up a KEYS file
yet? --That's also mentioned at
http://www.apache.org/dev/new-committers-guide.html#pgp .
-jean
Re: [REVIEW] Cayenne 2.0.1-incubating release
Posted by Andrus Adamchik <an...@objectstyle.org>.
On Sep 18, 2006, at 10:38 PM, Jean T. Anderson wrote:
> There's a handy licensing tool here (derby just used this for the
> recent
> license updating, which is how I found out about it):
> https://svn.apache.org/repos/private/committers/relicense/src/perl/
> insert_license.pl
>
> If you run it in practice mode (-p) it doesn't actually do anything
> but
> provides a report of what needs to be done; e.g. here's what I just
> did:
>
> insert_license.pl -p /opt/Apache/cayenne-2.0.1-incubating/src >&
> cayenne.log
>
> Here's the summary at the end of that cayenne.log output:
Addressing the issues that were found so far....
I just went through all the warnings in Jean's report and fixed those
that weren't false positives (there were a few - see full report
below). There was one file with dual licensing - _HessianServlet.java
- it is a patch to a bug in the Hessian servlet that requires access
to private variables. I removed Caucho license from the file and
added a note to the NOTICE file...
> I notice that recent incubator releases have the md5 sigs
> (http://people.apache.org/dist/incubator/tuscany/incubating-M1/ ,
> http://people.apache.org/dist/incubator/stdcxx/releases/ ,
> http://people.apache.org/dist/incubator/harmony/snapshots/ ) so that
> might be another thing to look into (more info is at
> http://www.apache.org/dev/release-signing.html)
When we finish the review, I'll post the new release with the
signatures. Although my PGP key is not known to anybody, defeating
the purpose of signing. So I guess we can limit this to just MD5's.
Andrus
------------
WARNINGS ADDRESSED
/opt/Apache/cayenne-2.0.1-incubating/src/modeler/org/apache/cayenne/
modeler/cayennemodeler-strings.properties,
/opt/Apache/cayenne-2.0.1-incubating/src/modeler/org/apache/cayenne/
modeler/event/DomainDisplayEvent.java
/opt/Apache/cayenne-2.0.1-incubating/src/cayenne/org/apache/cayenne/
remote/hessian/service/_HessianServlet.java
INSERTED LICENSES:
/opt/Apache/cayenne-2.0.1-incubating/src/modeler/org/apache/cayenne/
modeler/pref/DataMapDefaults.java
/opt/Apache/cayenne-2.0.1-incubating/src/modeler/org/apache/cayenne/
modeler/pref/DBGeneratorDefaults.java
/opt/Apache/cayenne-2.0.1-incubating/src/modeler/org/apache/cayenne/
modeler/pref/DataNodeDefaults.java
/opt/Apache/cayenne-2.0.1-incubating/src/cayenne/org/apache/cayenne/
dba/types.xml
FALSE POSITIVES:
/opt/Apache/cayenne-2.0.1-incubating/src/modeler/org/apache/cayenne/
pref/PreferenceService.java,
/opt/Apache/cayenne-2.0.1-incubating/src/cayenne/org/apache/cayenne/
project/validator/DomainValidator.java,
/opt/Apache/cayenne-2.0.1-incubating/src/cayenne/org/apache/cayenne/
map/event/DomainEvent.java,
GENERATED, WILL NOT INSERT A LICENCE:
/opt/Apache/cayenne-2.0.1-incubating/src/modeler/org/apache/cayenne/
pref/_DomainPreference.java,
/opt/Apache/cayenne-2.0.1-incubating/src/modeler/pref/cayenne.xml,
/opt/Apache/cayenne-2.0.1-incubating/src/modeler/pref/
HSQLNode.driver.xml,
/opt/Apache/cayenne-2.0.1-incubating/src/modeler/pref/
Preferences.map.xml,
/opt/Apache/cayenne-2.0.1-incubating/src/modeler/pref/
ModelerPreferences.map.xml,
/opt/Apache/cayenne-2.0.1-incubating/src/modeler/org/apache/cayenne/
modeler/pref/_DBConnectionInfo.java
/opt/Apache/cayenne-2.0.1-incubating/src/modeler/org/apache/cayenne/
modeler/pref/_DataMapDefaults.java
/opt/Apache/cayenne-2.0.1-incubating/src/modeler/org/apache/cayenne/
modeler/pref/_FSPath.java
/opt/Apache/cayenne-2.0.1-incubating/src/modeler/org/apache/cayenne/
modeler/pref/_ComponentGeometry.java,
/opt/Apache/cayenne-2.0.1-incubating/src/modeler/org/apache/cayenne/
modeler/pref/_DBGeneratorDefaults.java,
/opt/Apache/cayenne-2.0.1-incubating/src/modeler/org/apache/cayenne/
modeler/pref/_DataNodeDefaults.java,
/opt/Apache/cayenne-2.0.1-incubating/src/modeler/org/apache/cayenne/
pref/_Domain.java,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start/
cayenne-tutorial/src/UntitledDomainNode.driver.xml,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start/
cayenne-tutorial/src/UntitledDomainMap.map.xml,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start/
cayenne-tutorial/src/cayenne/tutorial/Artist.java,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start/
cayenne-tutorial/src/cayenne/tutorial/Painting.java,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start/
cayenne-tutorial/src/cayenne/tutorial/Gallery.java,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start/
cayenne-tutorial/src/cayenne/tutorial/auto/_Painting.java,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start/
cayenne-tutorial/src/cayenne/tutorial/auto/_Gallery.java,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start/
cayenne-tutorial/src/cayenne/tutorial/auto/_Artist.java,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start-rop/
cayenne-tutorial/src/cayenne.xml,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start-rop/
cayenne-tutorial/src/UntitledDomainNode.driver.xml,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start-rop/
cayenne-tutorial/src/UntitledDomainMap.map.xml,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start-rop/
cayenne-tutorial/src/cayenne/tutorial/Artist.java,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start-rop/
cayenne-tutorial/src/cayenne/tutorial/Painting.java,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start-rop/
cayenne-tutorial/src/cayenne/tutorial/Gallery.java,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start-rop/
cayenne-tutorial/src/cayenne/tutorial/auto/_Painting.java,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start-rop/
cayenne-tutorial/src/cayenne/tutorial/auto/_Gallery.java,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start-rop/
cayenne-tutorial/src/cayenne/tutorial/auto/_Artist.java,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start-rop/
cayenne-tutorial-client/src/cayenne/tutorial/client/Artist.java,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start-rop/
cayenne-tutorial-client/src/cayenne/tutorial/client/Painting.java,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start-rop/
cayenne-tutorial-client/src/cayenne/tutorial/client/Gallery.java,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start-rop/
cayenne-tutorial-client/src/cayenne/tutorial/client/auto/_Painting.java,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start-rop/
cayenne-tutorial-client/src/cayenne/tutorial/client/auto/_Gallery.java,
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start-rop/
cayenne-tutorial-client/src/cayenne/tutorial/client/auto/_Artist.java,
/opt/Apache/cayenne-2.0.1-incubating/src/cayenne/org/apache/cayenne/
exp/parser/ExpressionParserTreeConstants.java
/opt/Apache/cayenne-2.0.1-incubating/src/tutorials/quick-start/
cayenne-tutorial/src/cayenne.xml,