You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Peter N. Lundblad" <pe...@famlundblad.se> on 2005/12/03 22:26:54 UTC

Re: svn commit: r17613 - trunk/subversion/libsvn_wc

On Sat, 3 Dec 2005 maxb@tigris.org wrote:

> Author: maxb
> Date: Sat Dec  3 12:00:15 2005
> New Revision: 17613
>
> Modified:
>    trunk/subversion/libsvn_wc/props.c
>
> Log:
> * subversion/libsvn_wc/props.c (svn_wc__load_props): Silence warning.
>
>
Erik Húlsmann pointed out this warning on wc-propcaching some time ago.  A
discussion followed where I pointed out that GCC 4 adds a lot of these
warnings when you pass an uninitialized variable to a function as an "out"
parameter; it can't know that the function will set the variable before
using it.  So, this warning is pretty useless when using GCC 4.  I'm not
sure if we should continue to silence such warnings.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: svn commit: r17613 - trunk/subversion/libsvn_wc

Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Sat, 3 Dec 2005, Max Bowsher wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Peter N. Lundblad wrote:
> > On Sat, 3 Dec 2005 maxb@tigris.org wrote:
> >
> >>Author: maxb
> >>Date: Sat Dec  3 12:00:15 2005
> >>New Revision: 17613
> >>
> >>Modified:
> >>   trunk/subversion/libsvn_wc/props.c
> >>
> >>Log:
> >>* subversion/libsvn_wc/props.c (svn_wc__load_props): Silence warning.
> >
> > Erik Húlsmann pointed out this warning on wc-propcaching some time ago.  A
> > discussion followed where I pointed out that GCC 4 adds a lot of these
> > warnings when you pass an uninitialized variable to a function as an "out"
> > parameter; it can't know that the function will set the variable before
> > using it.  So, this warning is pretty useless when using GCC 4.  I'm not
> > sure if we should continue to silence such warnings.
>
> Then should we document that the official way build Subversion is with
> - -Wno-undefined?
>
Seems right to me, or change our coding style to always initialize things,
but I don't like that.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: svn commit: r17613 - trunk/subversion/libsvn_wc

Posted by mark benedetto king <mb...@lowlatency.com>.
On Sat, Dec 03, 2005 at 06:05:59PM -0500, David James wrote:
> On 12/3/05, Max Bowsher <ma...@ukf.net> wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Peter N. Lundblad wrote:
> > > On Sat, 3 Dec 2005 maxb@tigris.org wrote:
> > >
> > >>Author: maxb
> > >>Date: Sat Dec  3 12:00:15 2005
> > >>New Revision: 17613
> > >>
> > >>Modified:
> > >>   trunk/subversion/libsvn_wc/props.c
> > >>
> > >>Log:
> > >>* subversion/libsvn_wc/props.c (svn_wc__load_props): Silence warning.
> > >
> > > Erik H??lsmann pointed out this warning on wc-propcaching some time ago.  A
> > > discussion followed where I pointed out that GCC 4 adds a lot of these
> > > warnings when you pass an uninitialized variable to a function as an "out"
> > > parameter; it can't know that the function will set the variable before
> > > using it.  So, this warning is pretty useless when using GCC 4.  I'm not
> > > sure if we should continue to silence such warnings.
> >
> > Then should we document that the official way build Subversion is with
> > - -Wno-undefined?
> +1
> 

It's either that or contribute a patch to GCC that adds a function
attribute that tells the compiler what to do.

--ben


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r17613 - trunk/subversion/libsvn_wc

Posted by David James <ja...@cs.toronto.edu>.
On 12/3/05, Max Bowsher <ma...@ukf.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Peter N. Lundblad wrote:
> > On Sat, 3 Dec 2005 maxb@tigris.org wrote:
> >
> >>Author: maxb
> >>Date: Sat Dec  3 12:00:15 2005
> >>New Revision: 17613
> >>
> >>Modified:
> >>   trunk/subversion/libsvn_wc/props.c
> >>
> >>Log:
> >>* subversion/libsvn_wc/props.c (svn_wc__load_props): Silence warning.
> >
> > Erik Húlsmann pointed out this warning on wc-propcaching some time ago.  A
> > discussion followed where I pointed out that GCC 4 adds a lot of these
> > warnings when you pass an uninitialized variable to a function as an "out"
> > parameter; it can't know that the function will set the variable before
> > using it.  So, this warning is pretty useless when using GCC 4.  I'm not
> > sure if we should continue to silence such warnings.
>
> Then should we document that the official way build Subversion is with
> - -Wno-undefined?
+1

Cheers,

David

--
David James -- http://www.cs.toronto.edu/~james

Re: svn commit: r17613 - trunk/subversion/libsvn_wc

Posted by Max Bowsher <ma...@ukf.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Peter N. Lundblad wrote:
> On Sat, 3 Dec 2005 maxb@tigris.org wrote:
> 
>>Author: maxb
>>Date: Sat Dec  3 12:00:15 2005
>>New Revision: 17613
>>
>>Modified:
>>   trunk/subversion/libsvn_wc/props.c
>>
>>Log:
>>* subversion/libsvn_wc/props.c (svn_wc__load_props): Silence warning.
> 
> Erik Húlsmann pointed out this warning on wc-propcaching some time ago.  A
> discussion followed where I pointed out that GCC 4 adds a lot of these
> warnings when you pass an uninitialized variable to a function as an "out"
> parameter; it can't know that the function will set the variable before
> using it.  So, this warning is pretty useless when using GCC 4.  I'm not
> sure if we should continue to silence such warnings.

Then should we document that the official way build Subversion is with
- -Wno-undefined?

Max.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)

iD8DBQFDkiIwfFNSmcDyxYARAjydAKCpquQOinUlCLprEwcfyMqnhH3EvQCdGqMR
tDfL44CK5nv/cbD/S8vRd1k=
=IqY6
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org