You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/10/12 17:06:48 UTC
[GitHub] [incubator-linkis] jacktao007 opened a new pull request, #3629: fix(linkis-dist): optimized the install-kubernetes.sh script
jacktao007 opened a new pull request, #3629:
URL: https://github.com/apache/incubator-linkis/pull/3629
<!--
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
You can learn more about contributing to Apache Linkis here: https://linkis.apache.org/community/how-to-contribute
Happy contributing!
-->
### What is the purpose of the change
optimized the install-kubernetes.sh script.
### Brief change log
- optimized the install-kubernetes.sh script;
### Checklist
- [x] I have read the [Contributing Guidelines on pull requests](https://github.com/facebook/docusaurus/blob/main/CONTRIBUTING.md#pull-requests).
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [Linkis mailing list](https://linkis.apache.org/community/how-to-subscribe) first)
- [ ] **If this is a code change**: I have written unit tests to fully verify the new behavior.
<!--
Note
1. Mark the PR title as `[WIP] title` until it's ready to be reviewed.
如果PR还未准备好被review，请在标题上添加[WIP]标识(WIP work in progress)
2. Always add/update tests for any changes unless you have a good reason.
除非您有充分的理由，否则任何修改都需要添加/更新测试
3. Always update the documentation to reflect the changes made in the PR.
始终更新文档以反映 PR 中所做的更改
4. After the PR is submitted, please pay attention to the execution result of git action check.
If there is any failure, please adjust it in time
PR提交后，请关注git action check 执行结果，关键的check失败时，请及时修正
5. Before the pr is merged, if the commit is missing, you can continue to commit the code
在未合并前，如果提交有遗漏，您可以继续提交代码
6. After you submit PR, you can add assistant WeChat, the WeChat QR code is
https://user-images.githubusercontent.com/7869972/176336986-d6b9be8f-d1d3-45f1-aa45-8e6adf5dd244.png
您提交pr后，可以添加助手微信，微信二维码为
https://user-images.githubusercontent.com/7869972/176336986-d6b9be8f-d1d3-45f1-aa45-8e6adf5dd244.png
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jacktao007 commented on a diff in pull request #3629: fix(linkis-dist): optimized the install-kubernetes.sh script
Posted by GitBox <gi...@apache.org>.
jacktao007 commented on code in PR #3629:
URL: https://github.com/apache/incubator-linkis/pull/3629#discussion_r994369699
##########
linkis-dist/bin/install-kubernetes.sh:
##########
@@ -14,16 +14,182 @@
# limitations under the License.
#
-docker pull ghcr.io/apache/incubator-linkis/linkis-ldh:latest
-docker pull ghcr.io/apache/incubator-linkis/linkis:latest
-docker pull ghcr.io/apache/incubator-linkis/linkis-web:latest
-docker tag ghcr.io/apache/incubator-linkis/linkis:latest linkis:dev
-docker tag ghcr.io/apache/incubator-linkis/linkis-web:latest linkis-web:dev
-docker tag ghcr.io/apache/incubator-linkis/linkis-ldh:latest linkis-ldh:dev
-../docker/scripts/make-linikis-image-with-mysql-jdbc.sh
-docker tag linkis:with-jdbc linkis:dev
-../helm/scripts/create-kind-cluster.sh
-../helm/scripts/install-mysql.shl
-../helm/scripts/install-ldh.sh
-../helm/scripts/install-linkis.sh
-kubectl get pods -A
+#variable
+WORK_DIR=`cd $(dirname $0); pwd -P`
+MIRRORS="ghcr.io"
+COMMAND="pull-install"
+DEBUG=false
+WITH_LDH=false
+
+#help info
+help() {
+ echo "Command Describe"
+ echo "pull-install pull and install linkis images"
+ echo "install pull linkis images"
+ echo "pull pull linkis images"
+ echo "help print help info"
+ echo ""
+ echo "Params Describe"
+ echo "-m,--mirrors url (default:ghcr.io , eg: ghcr.dockerproxy.com)"
+ echo "-d,--debug print debug info"
+ echo "-l,--ldh install linkis with ldh"
+ echo ""
+ echo "example:"
+ echo "./install-kubernetes.sh pull pull image with ghcr.io"
+ echo "./install-kubernetes.sh pull -m ghcr.dockerproxy.com pull image with ghcr.dockerproxy.com"
+ echo "./install-kubernetes.sh install install linkis to kind and kubernetes"
+ echo "./install-kubernetes.sh pull-install -m ghcr.dockerproxy.com pull image and install linkis to kind and kubernetes"
+}
+
+#pull the container image of the linkis
+pull(){
+ docker pull $MIRRORS/apache/incubator-linkis/linkis-ldh:latest
+ docker pull $MIRRORS/apache/incubator-linkis/linkis:latest
+ docker pull $MIRRORS/apache/incubator-linkis/linkis-web:latest
+}
+#change the label
+tag(){
+ docker tag $MIRRORS/apache/incubator-linkis/linkis:latest linkis:dev
+ docker tag $MIRRORS/apache/incubator-linkis/linkis-web:latest linkis-web:dev
+ docker tag $MIRRORS/apache/incubator-linkis/linkis-ldh:latest linkis-ldh:dev
+}
+#create an image to carry mysql
+make-linikis-image-with-mysql-jdbc(){
+ ../docker/scripts/make-linikis-image-with-mysql-jdbc.sh
Review Comment:
好的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jacktao007 commented on a diff in pull request #3629: fix(linkis-dist): optimized the install-kubernetes.sh script
Posted by GitBox <gi...@apache.org>.
jacktao007 commented on code in PR #3629:
URL: https://github.com/apache/incubator-linkis/pull/3629#discussion_r994370182
##########
linkis-dist/bin/install-kubernetes.sh:
##########
@@ -14,16 +14,182 @@
# limitations under the License.
#
Review Comment:
install-linkis-to-kubernetes.sh
##########
linkis-dist/bin/install-kubernetes.sh:
##########
@@ -14,16 +14,182 @@
# limitations under the License.
#
-docker pull ghcr.io/apache/incubator-linkis/linkis-ldh:latest
-docker pull ghcr.io/apache/incubator-linkis/linkis:latest
-docker pull ghcr.io/apache/incubator-linkis/linkis-web:latest
-docker tag ghcr.io/apache/incubator-linkis/linkis:latest linkis:dev
-docker tag ghcr.io/apache/incubator-linkis/linkis-web:latest linkis-web:dev
-docker tag ghcr.io/apache/incubator-linkis/linkis-ldh:latest linkis-ldh:dev
-../docker/scripts/make-linikis-image-with-mysql-jdbc.sh
-docker tag linkis:with-jdbc linkis:dev
-../helm/scripts/create-kind-cluster.sh
-../helm/scripts/install-mysql.shl
-../helm/scripts/install-ldh.sh
-../helm/scripts/install-linkis.sh
-kubectl get pods -A
+#variable
+WORK_DIR=`cd $(dirname $0); pwd -P`
+MIRRORS="ghcr.io"
+COMMAND="pull-install"
+DEBUG=false
+WITH_LDH=false
+
+#help info
+help() {
+ echo "Command Describe"
+ echo "pull-install pull and install linkis images"
+ echo "install pull linkis images"
+ echo "pull pull linkis images"
+ echo "help print help info"
+ echo ""
+ echo "Params Describe"
+ echo "-m,--mirrors url (default:ghcr.io , eg: ghcr.dockerproxy.com)"
+ echo "-d,--debug print debug info"
+ echo "-l,--ldh install linkis with ldh"
+ echo ""
+ echo "example:"
+ echo "./install-kubernetes.sh pull pull image with ghcr.io"
+ echo "./install-kubernetes.sh pull -m ghcr.dockerproxy.com pull image with ghcr.dockerproxy.com"
+ echo "./install-kubernetes.sh install install linkis to kind and kubernetes"
+ echo "./install-kubernetes.sh pull-install -m ghcr.dockerproxy.com pull image and install linkis to kind and kubernetes"
+}
+
+#pull the container image of the linkis
+pull(){
+ docker pull $MIRRORS/apache/incubator-linkis/linkis-ldh:latest
Review Comment:
好的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone merged pull request #3629: fix(linkis-dist): optimized the install-kubernetes.sh script
Posted by GitBox <gi...@apache.org>.
casionone merged PR #3629:
URL: https://github.com/apache/incubator-linkis/pull/3629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jacktao007 commented on a diff in pull request #3629: fix(linkis-dist): optimized the install-kubernetes.sh script
Posted by GitBox <gi...@apache.org>.
jacktao007 commented on code in PR #3629:
URL: https://github.com/apache/incubator-linkis/pull/3629#discussion_r994370695
##########
linkis-dist/bin/install-kubernetes.sh:
##########
@@ -14,16 +14,182 @@
# limitations under the License.
#
-docker pull ghcr.io/apache/incubator-linkis/linkis-ldh:latest
-docker pull ghcr.io/apache/incubator-linkis/linkis:latest
-docker pull ghcr.io/apache/incubator-linkis/linkis-web:latest
-docker tag ghcr.io/apache/incubator-linkis/linkis:latest linkis:dev
-docker tag ghcr.io/apache/incubator-linkis/linkis-web:latest linkis-web:dev
-docker tag ghcr.io/apache/incubator-linkis/linkis-ldh:latest linkis-ldh:dev
-../docker/scripts/make-linikis-image-with-mysql-jdbc.sh
-docker tag linkis:with-jdbc linkis:dev
-../helm/scripts/create-kind-cluster.sh
-../helm/scripts/install-mysql.shl
-../helm/scripts/install-ldh.sh
-../helm/scripts/install-linkis.sh
-kubectl get pods -A
+#variable
+WORK_DIR=`cd $(dirname $0); pwd -P`
+MIRRORS="ghcr.io"
+COMMAND="pull-install"
+DEBUG=false
+WITH_LDH=false
+
+#help info
+help() {
+ echo "Command Describe"
+ echo "pull-install pull and install linkis images"
+ echo "install pull linkis images"
+ echo "pull pull linkis images"
+ echo "help print help info"
+ echo ""
+ echo "Params Describe"
+ echo "-m,--mirrors url (default:ghcr.io , eg: ghcr.dockerproxy.com)"
+ echo "-d,--debug print debug info"
+ echo "-l,--ldh install linkis with ldh"
+ echo ""
+ echo "example:"
+ echo "./install-kubernetes.sh pull pull image with ghcr.io"
+ echo "./install-kubernetes.sh pull -m ghcr.dockerproxy.com pull image with ghcr.dockerproxy.com"
+ echo "./install-kubernetes.sh install install linkis to kind and kubernetes"
+ echo "./install-kubernetes.sh pull-install -m ghcr.dockerproxy.com pull image and install linkis to kind and kubernetes"
+}
+
+#pull the container image of the linkis
+pull(){
+ docker pull $MIRRORS/apache/incubator-linkis/linkis-ldh:latest
+ docker pull $MIRRORS/apache/incubator-linkis/linkis:latest
+ docker pull $MIRRORS/apache/incubator-linkis/linkis-web:latest
+}
+#change the label
+tag(){
+ docker tag $MIRRORS/apache/incubator-linkis/linkis:latest linkis:dev
+ docker tag $MIRRORS/apache/incubator-linkis/linkis-web:latest linkis-web:dev
+ docker tag $MIRRORS/apache/incubator-linkis/linkis-ldh:latest linkis-ldh:dev
+}
+#create an image to carry mysql
+make-linikis-image-with-mysql-jdbc(){
+ ../docker/scripts/make-linikis-image-with-mysql-jdbc.sh
+ docker tag linkis:with-jdbc linkis:dev
+}
+#creating a kind cluster
+create-kind-cluster(){
+ ../helm/scripts/create-kind-cluster.sh
+}
+#mysql installation
+install-mysql(){
+ ../helm/scripts/install-mysql.sh
+}
+#ldh installation
+install-ldh(){
+ ../helm/scripts/install-ldh.sh
+}
+#linkis installation
+install-linkis(){
+ if [ $WITH_LDH = true ];then
+ ../helm/scripts/install-charts-with-ldh.sh
+ else
+ ../helm/scripts/install-linkis.sh
+ fi
+}
+#display pods
+display-pods(){
+ kubectl get pods -a
+}
+
+install(){
+ tag
+ make-linikis-image-with-mysql-jdbc
+ create-kind-cluster
+ install-mysql
+ install-ldh
+ install-linkis
+ display-pods
+}
+
+debug(){
+ if [ $DEBUG = true ]; then
+ echo $(date "+%Y-%m-%d %H:%M:%S") "debug: "$1
+ fi
+}
+
+info(){
+ echo $(date "+%Y-%m-%d %H:%M:%S") "info: "$1
+}
+
+
+check-docker(){
Review Comment:
好的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #3629: fix(linkis-dist): optimized the install-kubernetes.sh script
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #3629:
URL: https://github.com/apache/incubator-linkis/pull/3629#issuecomment-1276539523
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/3629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3629](https://codecov.io/gh/apache/incubator-linkis/pull/3629?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e03f310) into [dev-1.3.0](https://codecov.io/gh/apache/incubator-linkis/commit/759aa7275549d1cc12b3f0e248a72fdf3a9356be?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (759aa72) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## dev-1.3.0 #3629 +/- ##
============================================
Coverage 14.67% 14.68%
Complexity 1018 1018
============================================
Files 677 677
Lines 23759 23759
Branches 3543 3543
============================================
+ Hits 3487 3488 +1
Misses 19755 19755
+ Partials 517 516 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/3629?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/linkis/scheduler/queue/Consumer.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvQ29uc3VtZXIuc2NhbGE=) | `100.00% <0.00%> (+14.28%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #3629: fix(linkis-dist): optimized the install-kubernetes.sh script
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #3629:
URL: https://github.com/apache/incubator-linkis/pull/3629#discussion_r994055847
##########
linkis-dist/bin/install-kubernetes.sh:
##########
@@ -14,16 +14,182 @@
# limitations under the License.
#
-docker pull ghcr.io/apache/incubator-linkis/linkis-ldh:latest
-docker pull ghcr.io/apache/incubator-linkis/linkis:latest
-docker pull ghcr.io/apache/incubator-linkis/linkis-web:latest
-docker tag ghcr.io/apache/incubator-linkis/linkis:latest linkis:dev
-docker tag ghcr.io/apache/incubator-linkis/linkis-web:latest linkis-web:dev
-docker tag ghcr.io/apache/incubator-linkis/linkis-ldh:latest linkis-ldh:dev
-../docker/scripts/make-linikis-image-with-mysql-jdbc.sh
-docker tag linkis:with-jdbc linkis:dev
-../helm/scripts/create-kind-cluster.sh
-../helm/scripts/install-mysql.shl
-../helm/scripts/install-ldh.sh
-../helm/scripts/install-linkis.sh
-kubectl get pods -A
+#variable
+WORK_DIR=`cd $(dirname $0); pwd -P`
+MIRRORS="ghcr.io"
+COMMAND="pull-install"
+DEBUG=false
+WITH_LDH=false
+
+#help info
+help() {
+ echo "Command Describe"
+ echo "pull-install pull and install linkis images"
+ echo "install pull linkis images"
+ echo "pull pull linkis images"
+ echo "help print help info"
+ echo ""
+ echo "Params Describe"
+ echo "-m,--mirrors url (default:ghcr.io , eg: ghcr.dockerproxy.com)"
+ echo "-d,--debug print debug info"
+ echo "-l,--ldh install linkis with ldh"
+ echo ""
+ echo "example:"
+ echo "./install-kubernetes.sh pull pull image with ghcr.io"
+ echo "./install-kubernetes.sh pull -m ghcr.dockerproxy.com pull image with ghcr.dockerproxy.com"
+ echo "./install-kubernetes.sh install install linkis to kind and kubernetes"
+ echo "./install-kubernetes.sh pull-install -m ghcr.dockerproxy.com pull image and install linkis to kind and kubernetes"
+}
+
+#pull the container image of the linkis
+pull(){
+ docker pull $MIRRORS/apache/incubator-linkis/linkis-ldh:latest
+ docker pull $MIRRORS/apache/incubator-linkis/linkis:latest
+ docker pull $MIRRORS/apache/incubator-linkis/linkis-web:latest
+}
+#change the label
+tag(){
+ docker tag $MIRRORS/apache/incubator-linkis/linkis:latest linkis:dev
+ docker tag $MIRRORS/apache/incubator-linkis/linkis-web:latest linkis-web:dev
+ docker tag $MIRRORS/apache/incubator-linkis/linkis-ldh:latest linkis-ldh:dev
+}
+#create an image to carry mysql
+make-linikis-image-with-mysql-jdbc(){
+ ../docker/scripts/make-linikis-image-with-mysql-jdbc.sh
+ docker tag linkis:with-jdbc linkis:dev
+}
+#creating a kind cluster
+create-kind-cluster(){
+ ../helm/scripts/create-kind-cluster.sh
+}
+#mysql installation
+install-mysql(){
+ ../helm/scripts/install-mysql.sh
+}
+#ldh installation
+install-ldh(){
+ ../helm/scripts/install-ldh.sh
+}
+#linkis installation
+install-linkis(){
+ if [ $WITH_LDH = true ];then
+ ../helm/scripts/install-charts-with-ldh.sh
+ else
+ ../helm/scripts/install-linkis.sh
+ fi
+}
+#display pods
+display-pods(){
+ kubectl get pods -a
+}
+
+install(){
+ tag
+ make-linikis-image-with-mysql-jdbc
+ create-kind-cluster
+ install-mysql
+ install-ldh
+ install-linkis
+ display-pods
+}
+
+debug(){
+ if [ $DEBUG = true ]; then
+ echo $(date "+%Y-%m-%d %H:%M:%S") "debug: "$1
+ fi
+}
+
+info(){
+ echo $(date "+%Y-%m-%d %H:%M:%S") "info: "$1
+}
+
+
+check-docker(){
Review Comment:
function name with `-` may casue error about not a valid identifier
can replace with`_`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] AaronLinOops commented on a diff in pull request #3629: fix(linkis-dist): optimized the install-kubernetes.sh script
Posted by GitBox <gi...@apache.org>.
AaronLinOops commented on code in PR #3629:
URL: https://github.com/apache/incubator-linkis/pull/3629#discussion_r994022012
##########
linkis-dist/bin/install-kubernetes.sh:
##########
@@ -14,16 +14,182 @@
# limitations under the License.
#
-docker pull ghcr.io/apache/incubator-linkis/linkis-ldh:latest
-docker pull ghcr.io/apache/incubator-linkis/linkis:latest
-docker pull ghcr.io/apache/incubator-linkis/linkis-web:latest
-docker tag ghcr.io/apache/incubator-linkis/linkis:latest linkis:dev
-docker tag ghcr.io/apache/incubator-linkis/linkis-web:latest linkis-web:dev
-docker tag ghcr.io/apache/incubator-linkis/linkis-ldh:latest linkis-ldh:dev
-../docker/scripts/make-linikis-image-with-mysql-jdbc.sh
-docker tag linkis:with-jdbc linkis:dev
-../helm/scripts/create-kind-cluster.sh
-../helm/scripts/install-mysql.shl
-../helm/scripts/install-ldh.sh
-../helm/scripts/install-linkis.sh
-kubectl get pods -A
+#variable
+WORK_DIR=`cd $(dirname $0); pwd -P`
+MIRRORS="ghcr.io"
+COMMAND="pull-install"
+DEBUG=false
+WITH_LDH=false
+
+#help info
+help() {
+ echo "Command Describe"
+ echo "pull-install pull and install linkis images"
+ echo "install pull linkis images"
+ echo "pull pull linkis images"
+ echo "help print help info"
+ echo ""
+ echo "Params Describe"
+ echo "-m,--mirrors url (default:ghcr.io , eg: ghcr.dockerproxy.com)"
+ echo "-d,--debug print debug info"
+ echo "-l,--ldh install linkis with ldh"
+ echo ""
+ echo "example:"
+ echo "./install-kubernetes.sh pull pull image with ghcr.io"
+ echo "./install-kubernetes.sh pull -m ghcr.dockerproxy.com pull image with ghcr.dockerproxy.com"
+ echo "./install-kubernetes.sh install install linkis to kind and kubernetes"
+ echo "./install-kubernetes.sh pull-install -m ghcr.dockerproxy.com pull image and install linkis to kind and kubernetes"
+}
+
+#pull the container image of the linkis
+pull(){
+ docker pull $MIRRORS/apache/incubator-linkis/linkis-ldh:latest
+ docker pull $MIRRORS/apache/incubator-linkis/linkis:latest
+ docker pull $MIRRORS/apache/incubator-linkis/linkis-web:latest
+}
+#change the label
+tag(){
+ docker tag $MIRRORS/apache/incubator-linkis/linkis:latest linkis:dev
+ docker tag $MIRRORS/apache/incubator-linkis/linkis-web:latest linkis-web:dev
+ docker tag $MIRRORS/apache/incubator-linkis/linkis-ldh:latest linkis-ldh:dev
+}
+#create an image to carry mysql
+make-linikis-image-with-mysql-jdbc(){
+ ../docker/scripts/make-linikis-image-with-mysql-jdbc.sh
Review Comment:
使用 ${WORK_DIR}/linkis-dist/docker/... 这样的路径是不是更好一些？
##########
linkis-dist/bin/install-kubernetes.sh:
##########
@@ -14,16 +14,182 @@
# limitations under the License.
#
Review Comment:
脚本名称为 install-kubernetes.sh 给人感觉像是要安装 k8s ，是否有更合适一些的名称？
##########
linkis-dist/bin/install-kubernetes.sh:
##########
@@ -14,16 +14,182 @@
# limitations under the License.
#
-docker pull ghcr.io/apache/incubator-linkis/linkis-ldh:latest
-docker pull ghcr.io/apache/incubator-linkis/linkis:latest
-docker pull ghcr.io/apache/incubator-linkis/linkis-web:latest
-docker tag ghcr.io/apache/incubator-linkis/linkis:latest linkis:dev
-docker tag ghcr.io/apache/incubator-linkis/linkis-web:latest linkis-web:dev
-docker tag ghcr.io/apache/incubator-linkis/linkis-ldh:latest linkis-ldh:dev
-../docker/scripts/make-linikis-image-with-mysql-jdbc.sh
-docker tag linkis:with-jdbc linkis:dev
-../helm/scripts/create-kind-cluster.sh
-../helm/scripts/install-mysql.shl
-../helm/scripts/install-ldh.sh
-../helm/scripts/install-linkis.sh
-kubectl get pods -A
+#variable
+WORK_DIR=`cd $(dirname $0); pwd -P`
+MIRRORS="ghcr.io"
+COMMAND="pull-install"
+DEBUG=false
+WITH_LDH=false
+
+#help info
+help() {
+ echo "Command Describe"
+ echo "pull-install pull and install linkis images"
+ echo "install pull linkis images"
+ echo "pull pull linkis images"
+ echo "help print help info"
+ echo ""
+ echo "Params Describe"
+ echo "-m,--mirrors url (default:ghcr.io , eg: ghcr.dockerproxy.com)"
+ echo "-d,--debug print debug info"
+ echo "-l,--ldh install linkis with ldh"
+ echo ""
+ echo "example:"
+ echo "./install-kubernetes.sh pull pull image with ghcr.io"
+ echo "./install-kubernetes.sh pull -m ghcr.dockerproxy.com pull image with ghcr.dockerproxy.com"
+ echo "./install-kubernetes.sh install install linkis to kind and kubernetes"
+ echo "./install-kubernetes.sh pull-install -m ghcr.dockerproxy.com pull image and install linkis to kind and kubernetes"
+}
+
+#pull the container image of the linkis
+pull(){
+ docker pull $MIRRORS/apache/incubator-linkis/linkis-ldh:latest
Review Comment:
tag名称是否可以参数化，指定具体的tag，默认是 latest ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org