You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/22 11:21:20 UTC

[GitHub] [pulsar] nicoloboschi commented on pull request #19024: Update .asf.yaml to avoid merge PRs without approvals to the active release branches

nicoloboschi commented on PR #19024:
URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1362721394

   > @nicoloboschi IIUC `required_pull_request_reviews` infers `Require a pull request before merging` thus it's impossible after this change gets merged.
   
   yes that's what I thought. There's no difference in the new config with the master branch so I guess it wouldn't be possible anymore.
   
   If so, we cannot enforce for every cherry-pick to open a pull request, it would create a big noise in the repository without value.
   I think we can just advise on the mailing list to wait (and ask!) for a review in case of hard conflicts, for the sake of the project itself


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org