You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Henri Yandell (JIRA)" <ji...@apache.org> on 2011/03/03 05:35:36 UTC
[jira] Closed: (LANG-677) DateUtils.isSameLocalTime does not work
correct
[ https://issues.apache.org/jira/browse/LANG-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Yandell closed LANG-677.
------------------------------
Resolution: Fixed
Fix Version/s: (was: 3.1)
3.0
> DateUtils.isSameLocalTime does not work correct
> -----------------------------------------------
>
> Key: LANG-677
> URL: https://issues.apache.org/jira/browse/LANG-677
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.time.*
> Environment: linux 2.6.32-28, java version "1.6.0_22"
> Reporter: Christian
> Fix For: 3.0, 2.x
>
>
> Hi, I think I found a bug in the DateUtils class in the method isSameLocalTime.
> Example:
> Calendar a = Calendar.getInstance();
> a.setTimeInMillis(1297364400000L);
> Calendar b = Calendar.getInstance();
> b.setTimeInMillis(1297321200000L);
> Assert.assertFalse(DateUtils.isSameLocalTime(a, b));
> This is because the method compares
> cal1.get(Calendar.HOUR) == cal2.get(Calendar.HOUR)
> but I think it has to be
> cal1.get(Calendar.HOUR_OF_DAY) == cal2.get(Calendar.HOUR_OF_DAY)
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira