You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/06/02 22:00:22 UTC
[Impala-ASF-CR] IMPALA-5348: [DOCS] Add CAST to string literal + INTERVAL example
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7067
Change subject: IMPALA-5348: [DOCS] Add CAST to string literal + INTERVAL example
......................................................................
IMPALA-5348: [DOCS] Add CAST to string literal + INTERVAL example
The related JIRAs IMPALA-2293 and IMPALA-1503 are asking for the
code behavior to be changed to match the documentation. In the
meantime, changing the documentation to match the code.
I grepped the doc source for other instances of INTERVAL arithmetic
and this was the only one that used a string literal as the
starting point.
Change-Id: I3e2af386176e7c310ced221fa77d73c97a9f8590
---
M docs/topics/impala_literals.xml
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/7067/1
--
To view, visit http://gerrit.cloudera.org:8080/7067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e2af386176e7c310ced221fa77d73c97a9f8590
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-5348: [DOCS] Add CAST to string literal + INTERVAL example
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5348: [DOCS] Add CAST to string literal + INTERVAL example
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e2af386176e7c310ced221fa77d73c97a9f8590
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5348: [DOCS] Add CAST to string literal + INTERVAL example
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5348: [DOCS] Add CAST to string literal + INTERVAL example
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/125/
--
To view, visit http://gerrit.cloudera.org:8080/7067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e2af386176e7c310ced221fa77d73c97a9f8590
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5348: [DOCS] Add CAST to string literal + INTERVAL example
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-5348: [DOCS] Add CAST to string literal + INTERVAL example
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7067/1/docs/topics/impala_literals.xml
File docs/topics/impala_literals.xml:
Line 302: such as <codeph>CAST('1966-07-30' AS TIMESTAMP) + INTERVAL 5 YEARS + INTERVAL 3 DAYS</codeph>. See
> Cool, thanks for doing this. Does it make sense to mention explicitly that
I would say no because the example is correct regardless of the status of IMPALA-1503, while if I added more detail that would mean more changes to unwind after IMPALA-1503 was closed - I'd say that's an unnecessary maintenance burden.
--
To view, visit http://gerrit.cloudera.org:8080/7067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e2af386176e7c310ced221fa77d73c97a9f8590
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5348: [DOCS] Add CAST to string literal + INTERVAL example
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5348: [DOCS] Add CAST to string literal + INTERVAL example
......................................................................
IMPALA-5348: [DOCS] Add CAST to string literal + INTERVAL example
The related JIRAs IMPALA-2293 and IMPALA-1503 are asking for the
code behavior to be changed to match the documentation. In the
meantime, changing the documentation to match the code.
I grepped the doc source for other instances of INTERVAL arithmetic
and this was the only one that used a string literal as the
starting point.
Change-Id: I3e2af386176e7c310ced221fa77d73c97a9f8590
Reviewed-on: http://gerrit.cloudera.org:8080/7067
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_literals.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Michael Brown: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e2af386176e7c310ced221fa77d73c97a9f8590
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-5348: [DOCS] Add CAST to string literal + INTERVAL example
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-5348: [DOCS] Add CAST to string literal + INTERVAL example
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7067/1/docs/topics/impala_literals.xml
File docs/topics/impala_literals.xml:
Line 302: such as <codeph>CAST('1966-07-30' AS TIMESTAMP) + INTERVAL 5 YEARS + INTERVAL 3 DAYS</codeph>. See
Cool, thanks for doing this. Does it make sense to mention explicitly that the CAST() is necessary due to known issue IMPALA-1503?
--
To view, visit http://gerrit.cloudera.org:8080/7067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e2af386176e7c310ced221fa77d73c97a9f8590
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5348: [DOCS] Add CAST to string literal + INTERVAL example
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-5348: [DOCS] Add CAST to string literal + INTERVAL example
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e2af386176e7c310ced221fa77d73c97a9f8590
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No