You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/20 11:07:54 UTC

[GitHub] [apisix-dashboard] liuxiran opened a new issue #837: [Proposal]: Refactor Route publish and offline

liuxiran opened a new issue #837:
URL: https://github.com/apache/apisix-dashboard/issues/837


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Feature or performance improvement
   
   Refer to: 
   #611
   #437 
   
   
   ### Refactor:
   
   - APISIX implement Route publish/offline status in dp (issue: https://github.com/apache/apisix/issues/2737)
   
   - manager-api provides an interface to write data to etcd
   
   - fe add publish and offline button to every route item list table, at the same time, create route also need to add a publish form item.
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan closed issue #837: feat: Refactor Route publish and offline

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #837:
URL: https://github.com/apache/apisix-dashboard/issues/837


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] LiteSun commented on issue #837: [Proposal]: Refactor Route publish and offline

Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #837:
URL: https://github.com/apache/apisix-dashboard/issues/837#issuecomment-731912534


   I think this issue should be kept in sync with the apisix (issue: https://github.com/apache/apisix/issues/2737) milestone.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen commented on issue #837: [Proposal]: Refactor Route publish and offline

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #837:
URL: https://github.com/apache/apisix-dashboard/issues/837#issuecomment-731514856


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] membphis commented on issue #837: [Proposal]: Refactor Route publish and offline

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #837:
URL: https://github.com/apache/apisix-dashboard/issues/837#issuecomment-739770309


   this feature depends on https://github.com/apache/apisix/pull/2943
   
   we need to release a new version of APISIX. so I want to change the milestone to `2.3`
   
   @liuxiran @nic-chen please confirm if this is ok ^_^


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] LiteSun commented on issue #837: [Proposal]: Refactor Route publish and offline

Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #837:
URL: https://github.com/apache/apisix-dashboard/issues/837#issuecomment-743035487


   Just for reminder: [apache/apisix#2943](https://github.com/apache/apisix/pull/2943) is merged two days ago. cc @liuxiran 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #837: [Proposal]: Refactor Route publish and offline

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #837:
URL: https://github.com/apache/apisix-dashboard/issues/837#issuecomment-731909220


   Then do we have a final plan? dev, due date, and so on.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] moonming commented on issue #837: [Proposal]: Refactor Route publish and offline

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #837:
URL: https://github.com/apache/apisix-dashboard/issues/837#issuecomment-739641739


   What is the progress in dashboard? @liuxiran @nic-chen 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #837: [Proposal]: Refactor Route publish and offline

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #837:
URL: https://github.com/apache/apisix-dashboard/issues/837#issuecomment-731115213


   cc @nic-chen 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] liuxiran commented on issue #837: [Proposal]: Refactor Route publish and offline

Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #837:
URL: https://github.com/apache/apisix-dashboard/issues/837#issuecomment-739774930


   > this feature depends on [apache/apisix#2943](https://github.com/apache/apisix/pull/2943)
   > 
   > we need to release a new version of APISIX. so I want to change the milestone to `2.3`
   > 
   > @liuxiran @nic-chen please confirm if this is ok ^_^
   
   ok, and related pr for fe and manager-api will be created as a draft later this week.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] LiteSun edited a comment on issue #837: [Proposal]: Refactor Route publish and offline

Posted by GitBox <gi...@apache.org>.
LiteSun edited a comment on issue #837:
URL: https://github.com/apache/apisix-dashboard/issues/837#issuecomment-743035487


   Just for reminder: [apache/apisix#2943](https://github.com/apache/apisix/pull/2943) is merged. cc @liuxiran 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] moonming commented on issue #837: [Proposal]: Refactor Route publish and offline

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #837:
URL: https://github.com/apache/apisix-dashboard/issues/837#issuecomment-739641606


   This PR is in 2.2 milestone, and Apache APISIX supports it in https://github.com/apache/apisix/pull/2943
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org