[GitHub] [hive] jcamachor commented on a change in pull request #2119: HIVE-24854: Incremental MV refresh in presence of update/delete operations

[GitBox <gi...@apache.org>]

jcamachor commented on a change in pull request #2119:
URL: https://github.com/apache/hive/pull/2119#discussion_r610292866



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableScan.java
##########
@@ -263,6 +279,10 @@ public boolean isInsideView() {
     return insideView;
   }
 
+  public boolean isFetchDeletedRows() {
+    return fetchDeletedRows;
+  }
+
   // We need to include isInsideView inside digest to differentiate direct
   // tables and tables inside view. Otherwise, Calcite will treat them as the same.
   // Also include partition list key to trigger cost evaluation even if an

Review comment:
       The `computeDigest` method should include `fetchDeletedRows` in the computed digest.
   Otherwise, if you would have a plan with two TS on the same table, one with `fetchDeletedRows` set to `true` and another one set to `false`, the planner may merge those TS operators and take a single one of them.
   Maybe you can try to reproduce it with a custom test and add it to the patch.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org