You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Christian Schneider (JIRA)" <ji...@apache.org> on 2008/06/04 01:03:00 UTC
[jira] Created: (CAMEL-573) Remove cycle between builder and impl
Remove cycle between builder and impl
-------------------------------------
Key: CAMEL-573
URL: https://issues.apache.org/activemq/browse/CAMEL-573
Project: Apache Camel
Issue Type: Improvement
Components: camel-core
Reporter: Christian Schneider
Fix For: 1.4.0
Attachments: remove_cycle_between_impl_and_builder.patch
The following classes from impl are only used in builder. They should be moved there.
- NoRouteBuilder
- PredicateSupport
- BinaryPredicateSupport
The last dependency from impl to builder is in PredicateSupport. The method matches uses the static method PredicateBuilder.evaluateValuePredicate(value). The implementation of this method does not depend on anything so I would move it to util.ObjectHelper.
I have added a patch with alle these modifications. According to my structure 101 I see only improvements in the dependecies. The cycle between impl an builder vanishes. I think there is almost no risk in doing this modification.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-573) Remove cycle between builder and impl
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43246#action_43246 ]
Christian Schneider commented on CAMEL-573:
-------------------------------------------
I think NoRouteBuilder is now in builder and in impl. Could you please delete the obsolete class in impl?
> Remove cycle between builder and impl
> -------------------------------------
>
> Key: CAMEL-573
> URL: https://issues.apache.org/activemq/browse/CAMEL-573
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 1.4.0
>
> Attachments: remove_cycle_between_impl_and_builder.patch, remove_cycle_between_impl_and_builder.patch
>
>
> The following classes from impl are only used in builder. They should be moved there.
> - NoRouteBuilder
> - PredicateSupport
> - BinaryPredicateSupport
> The last dependency from impl to builder is in PredicateSupport. The method matches uses the static method PredicateBuilder.evaluateValuePredicate(value). The implementation of this method does not depend on anything so I would move it to util.ObjectHelper.
> I have added a patch with alle these modifications. According to my structure 101 I see only improvements in the dependecies. The cycle between impl an builder vanishes. I think there is almost no risk in doing this modification.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-573) Remove cycle between builder and impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43247#action_43247 ]
Claus Ibsen commented on CAMEL-573:
-----------------------------------
Deleting camel-core\src\main\java\org\apache\camel\impl\NoRouteBuilder.java
Committed revision 663471.
> Remove cycle between builder and impl
> -------------------------------------
>
> Key: CAMEL-573
> URL: https://issues.apache.org/activemq/browse/CAMEL-573
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 1.4.0
>
> Attachments: remove_cycle_between_impl_and_builder.patch, remove_cycle_between_impl_and_builder.patch
>
>
> The following classes from impl are only used in builder. They should be moved there.
> - NoRouteBuilder
> - PredicateSupport
> - BinaryPredicateSupport
> The last dependency from impl to builder is in PredicateSupport. The method matches uses the static method PredicateBuilder.evaluateValuePredicate(value). The implementation of this method does not depend on anything so I would move it to util.ObjectHelper.
> I have added a patch with alle these modifications. According to my structure 101 I see only improvements in the dependecies. The cycle between impl an builder vanishes. I think there is almost no risk in doing this modification.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-573) Remove cycle between builder and impl
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43204#action_43204 ]
Christian Schneider commented on CAMEL-573:
-------------------------------------------
The last dependency was in ExpressionSupport not in PredicateSupport. Sorry for the typo.
> Remove cycle between builder and impl
> -------------------------------------
>
> Key: CAMEL-573
> URL: https://issues.apache.org/activemq/browse/CAMEL-573
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Christian Schneider
> Fix For: 1.4.0
>
> Attachments: remove_cycle_between_impl_and_builder.patch
>
>
> The following classes from impl are only used in builder. They should be moved there.
> - NoRouteBuilder
> - PredicateSupport
> - BinaryPredicateSupport
> The last dependency from impl to builder is in PredicateSupport. The method matches uses the static method PredicateBuilder.evaluateValuePredicate(value). The implementation of this method does not depend on anything so I would move it to util.ObjectHelper.
> I have added a patch with alle these modifications. According to my structure 101 I see only improvements in the dependecies. The cycle between impl an builder vanishes. I think there is almost no risk in doing this modification.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-573) Remove cycle between builder and impl
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang resolved CAMEL-573.
--------------------------------
Resolution: Fixed
Patch applied with thanks to Christian.
The committed revision is 663018.
> Remove cycle between builder and impl
> -------------------------------------
>
> Key: CAMEL-573
> URL: https://issues.apache.org/activemq/browse/CAMEL-573
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 1.4.0
>
> Attachments: remove_cycle_between_impl_and_builder.patch, remove_cycle_between_impl_and_builder.patch
>
>
> The following classes from impl are only used in builder. They should be moved there.
> - NoRouteBuilder
> - PredicateSupport
> - BinaryPredicateSupport
> The last dependency from impl to builder is in PredicateSupport. The method matches uses the static method PredicateBuilder.evaluateValuePredicate(value). The implementation of this method does not depend on anything so I would move it to util.ObjectHelper.
> I have added a patch with alle these modifications. According to my structure 101 I see only improvements in the dependecies. The cycle between impl an builder vanishes. I think there is almost no risk in doing this modification.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-573) Remove cycle between builder and impl
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang reassigned CAMEL-573:
----------------------------------
Assignee: Willem Jiang
> Remove cycle between builder and impl
> -------------------------------------
>
> Key: CAMEL-573
> URL: https://issues.apache.org/activemq/browse/CAMEL-573
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 1.4.0
>
> Attachments: remove_cycle_between_impl_and_builder.patch, remove_cycle_between_impl_and_builder.patch
>
>
> The following classes from impl are only used in builder. They should be moved there.
> - NoRouteBuilder
> - PredicateSupport
> - BinaryPredicateSupport
> The last dependency from impl to builder is in PredicateSupport. The method matches uses the static method PredicateBuilder.evaluateValuePredicate(value). The implementation of this method does not depend on anything so I would move it to util.ObjectHelper.
> I have added a patch with alle these modifications. According to my structure 101 I see only improvements in the dependecies. The cycle between impl an builder vanishes. I think there is almost no risk in doing this modification.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-573) Remove cycle between builder and impl
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43209#action_43209 ]
Claus Ibsen commented on CAMEL-573:
-----------------------------------
Christian could you re add the patch with the ASF license granted. (ie apache icon next to the attached file).
JIRA has an issue that you can not do this when you create the ticket. You have to do it in 2 steps
1. Create the ticket
2. Attach the patch file with the ASF license granted.
Otherwise a really great patch that does remove the tangle. Keep up the great discoveries and good work you are doing. It is coming along nice and steady.
> Remove cycle between builder and impl
> -------------------------------------
>
> Key: CAMEL-573
> URL: https://issues.apache.org/activemq/browse/CAMEL-573
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Christian Schneider
> Fix For: 1.4.0
>
> Attachments: remove_cycle_between_impl_and_builder.patch
>
>
> The following classes from impl are only used in builder. They should be moved there.
> - NoRouteBuilder
> - PredicateSupport
> - BinaryPredicateSupport
> The last dependency from impl to builder is in PredicateSupport. The method matches uses the static method PredicateBuilder.evaluateValuePredicate(value). The implementation of this method does not depend on anything so I would move it to util.ObjectHelper.
> I have added a patch with alle these modifications. According to my structure 101 I see only improvements in the dependecies. The cycle between impl an builder vanishes. I think there is almost no risk in doing this modification.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-573) Remove cycle between builder and impl
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider updated CAMEL-573:
--------------------------------------
Attachment: remove_cycle_between_impl_and_builder.patch
> Remove cycle between builder and impl
> -------------------------------------
>
> Key: CAMEL-573
> URL: https://issues.apache.org/activemq/browse/CAMEL-573
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Christian Schneider
> Fix For: 1.4.0
>
> Attachments: remove_cycle_between_impl_and_builder.patch, remove_cycle_between_impl_and_builder.patch
>
>
> The following classes from impl are only used in builder. They should be moved there.
> - NoRouteBuilder
> - PredicateSupport
> - BinaryPredicateSupport
> The last dependency from impl to builder is in PredicateSupport. The method matches uses the static method PredicateBuilder.evaluateValuePredicate(value). The implementation of this method does not depend on anything so I would move it to util.ObjectHelper.
> I have added a patch with alle these modifications. According to my structure 101 I see only improvements in the dependecies. The cycle between impl an builder vanishes. I think there is almost no risk in doing this modification.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (CAMEL-573) Remove cycle between builder and impl
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang closed CAMEL-573.
------------------------------
> Remove cycle between builder and impl
> -------------------------------------
>
> Key: CAMEL-573
> URL: https://issues.apache.org/activemq/browse/CAMEL-573
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Christian Schneider
> Assignee: Willem Jiang
> Fix For: 1.4.0
>
> Attachments: remove_cycle_between_impl_and_builder.patch, remove_cycle_between_impl_and_builder.patch
>
>
> The following classes from impl are only used in builder. They should be moved there.
> - NoRouteBuilder
> - PredicateSupport
> - BinaryPredicateSupport
> The last dependency from impl to builder is in PredicateSupport. The method matches uses the static method PredicateBuilder.evaluateValuePredicate(value). The implementation of this method does not depend on anything so I would move it to util.ObjectHelper.
> I have added a patch with alle these modifications. According to my structure 101 I see only improvements in the dependecies. The cycle between impl an builder vanishes. I think there is almost no risk in doing this modification.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.