[GH] (pekko-projection/port-akka-999-grpc-populate-seen): Workflow run "Integration Tests for R2DBC" failed!

[GitBox <gi...@apache.org>]

The GitHub Actions job "Integration Tests for R2DBC" on pekko-projection.git/port-akka-999-grpc-populate-seen has failed.
Run started by GitHub user pjfanning (triggered by pjfanning).

Head commit for run:
01348a74173cfcb45dd474396cf637c4b10d0d5c / PJ Fanning <pj...@users.noreply.github.com>
grpc: populate offset seen from the event when it is omitted

Motivation:
The `seen` entries of the protocol Offset are redundant when they only
contain the persistence id and sequence number of the enclosing Event or
FilteredEvent. akka/akka-projection#999 made the consumer tolerate an
empty `seen` so that producers can omit it.

Modification:
When converting an Event or FilteredEvent to an EventEnvelope, the gRPC
consumer now fills in `seen` with persistenceId -> seqNr of the enclosing
event if the protocol offset has no `seen` entries. The conversion was
moved to an internal helper in the GrpcReadJournal companion so it can be
tested directly. The proto comment documents the optional `seen`.

Result:
Consumers handle offsets without `seen` correctly. Producers still send
`seen`, so this is only receiver-side tolerance and is safe for rolling
upgrades.

Tests:
- sbt "grpc-test/Test/testOnly org.apache.pekko.projection.grpc.consumer.scaladsl.GrpcReadJournalOffsetSpec" - failed before the fix (1 of 2), passes after
- grpc/mimaReportBinaryIssues not applicable - MiMa is disabled for the grpc module (new in 2.0.0)

References:
Refs akka/akka-projection#999 (https://github.com/akka/akka-projection/pull/999) - source of the ported code

Report URL: https://github.com/apache/pekko-projection/actions/runs/40145238268

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org