You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/11 11:36:58 UTC

[GitHub] [superset] zhaoyongjie commented on pull request #17680: fix: replace datamask with key from new key value api

zhaoyongjie commented on pull request #17680:
URL: https://github.com/apache/superset/pull/17680#issuecomment-991610310


   BTW:
   I found a potential security issues when I review this PR. The user can create a cache from this `put` method. This can constitute a memory attack.
   
   We have to fix this issue in separate PR. @michael-s-molina @pkdotson 
   
   https://user-images.githubusercontent.com/2016594/145674947-84b4d336-28b2-4f48-a882-cb91a82c6ee5.mov
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org