You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/23 14:26:44 UTC

[GitHub] [spark] srowen commented on a change in pull request #30679: [SPARK-33717][LAUNCHER] deprecate spark.launcher.childConectionTimeout

srowen commented on a change in pull request #30679:
URL: https://github.com/apache/spark/pull/30679#discussion_r599616645



##########
File path: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java
##########
@@ -89,11 +89,21 @@
    */
   public static final String NO_RESOURCE = "spark-internal";
 
+  /**
+   * Maximum time (in ms) to wait for a child process to connect back to the launcher server
+   * when using @link{#start()}.
+   *
+   * @deprecated use `CHILD_CONNECTION_TIMEOUT`
+   * @since ???

Review comment:
       Looks like 1.6.0, FWIW. You can add that or remove this tag.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org