You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/03 04:34:18 UTC

[GitHub] [arrow] nevi-me commented on a change in pull request #8820: ARROW-10791: [Rust] StreamReader, read_dictionary duplicating schema info

nevi-me commented on a change in pull request #8820:
URL: https://github.com/apache/arrow/pull/8820#discussion_r534660714



##########
File path: rust/integration-testing/src/bin/arrow-json-integration-test.rs
##########
@@ -489,7 +489,12 @@ fn array_from_json(
             Ok(Arc::new(array))
         }
         DataType::Dictionary(key_type, value_type) => {
-            let dict_id = field.dict_id();
+            let dict_id = field.dict_id().ok_or_else(|| {

Review comment:
       I apologise, I do remember this change, but I'm not sure of what happened; I presume while I was rebasing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org