You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2019/12/06 14:27:39 UTC

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #322: HDDS-2684. Refactor common test utilities to hadoop-hdds/common

adoroszlai opened a new pull request #322: HDDS-2684. Refactor common test utilities to hadoop-hdds/common
URL: https://github.com/apache/hadoop-ozone/pull/322
 
 
   ## What changes were proposed in this pull request?
   
   Expose test code from `hadoop-hdds/common` to other modules.  Move some "common" test utilities (random `DatanodeDetails` and `Pipeline` creation).  The goal is to be able to write unit tests for `client` module without code duplication.
   
   This was partly extracted from #271:
   
    * Avoid using real config properties (eg. `ozone.scm.client.bind.host`) for testing config file generation.  The generated config file is picked up by other tests and causes failures.
    * Rename Log4J2 config file used by audit logger test to avoid creating an untracked `audit.log` (similar to [HDDS-2063](https://issues.apache.org/jira/browse/HDDS-2063)).  This would happen if some test starts components which use audit logger, and it picks up `log4j2.properties` by default.
   
   https://issues.apache.org/jira/browse/HDDS-2684
   
   ## How was this patch tested?
   
   https://github.com/adoroszlai/hadoop-ozone/runs/336769633

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org