You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Alejandro Abdelnur (JIRA)" <ji...@apache.org> on 2013/09/16 15:21:57 UTC

[jira] [Commented] (MAPREDUCE-5487) In task processes, JobConf is unnecessarily loaded again in Limits

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768302#comment-13768302 ] 

Alejandro Abdelnur commented on MAPREDUCE-5487:
-----------------------------------------------

Shouldn't {{Limits.init(job)}} be called after adding the mapred config as resource?

Personally, I don't like constants that are not 'constants', that seems to be the case of these limits. I know this is not being introduced by this patch. I would change all code to use the methods and deprecate the constants. I'm OK with doing that in another patch though.
                
> In task processes, JobConf is unnecessarily loaded again in Limits
> ------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5487
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5487
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: performance, task
>    Affects Versions: 2.1.0-beta
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: MAPREDUCE-5487-1.patch, MAPREDUCE-5487.patch
>
>
> Limits statically loads a JobConf, which incurs costs of reading files from disk and parsing XML.  The contents of this JobConf are identical to the one loaded by YarnChild (before adding job.xml as a resource).  Allowing Limits to initialize with the JobConf loaded in YarnChild would reduce task startup time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira