You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@commons.apache.org by "P. Ottlinger" <po...@apache.org> on 2018/09/06 18:49:11 UTC

[lang3] Problem with the OSGi metadata: Bundle-SymbolicName / breaking change between 3.7 and 3.8

Hi,

I've just stumbled upon a problem that prevents me from updating from
3.7 to 3.8 in an OSGi context.

Although the release has just been a patch one, the bundle's symbolic
name changed
from "Bundle-SymbolicName org.apache.commons.lang3" in 3.7.0
to "Bundle-SymbolicName org.apache.commons.commons-lang3" in 3.8.0.

That makes it impossible to do a drop-in update, as it is a breaking change.

Is that change an error in 3.8.0 or a wanted one that could be
communicated more directly to downstream users?

May I file a bugticket in the LANG-Jira for it? I assume there has been
a hickup when building the OSGi release JAR and the change was not intended.

Thanks,
Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
For additional commands, e-mail: user-help@commons.apache.org


Re: [lang3] Problem with the OSGi metadata: Bundle-SymbolicName / breaking change between 3.7 and 3.8

Posted by Benedikt Ritter <br...@apache.org>.
I've checked the commons-csv build, since commons-lang is somehow special
because of the componentId being lang3 (we talked about this on the other
thread). It looks like this change also broke commons-csv. I think we
should revert it.

Benedikt

Am Mi., 19. Sep. 2018 um 10:25 Uhr schrieb Benedikt Ritter <
britter@apache.org>:

> ... bringing this to the developers list...
>
> I think this issue has been caused by this change:
> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?r1=1833874&r2=1833926
>
> I don't understand why an update of the commons build plugin had to change
> the OSGi meta data being generated. Maybe the change
> to commons.osgi.symbolicName was by accident? Can it be reverted?
>
> Regards,
> Benedikt
>
> Am Do., 6. Sep. 2018 um 21:35 Uhr schrieb P. Ottlinger <
> pottlinger@apache.org>:
>
>> Hi,
>>
>> thanks for quick response ...
>>
>> Am 06.09.2018 um 21:24 schrieb Oliver Heger:
>> > So opening a ticket in Jira would be the correct action to take.
>>
>> https://issues.apache.org/jira/browse/LANG-1419
>>
>> Done :-) Hopefully I didn't miss any important stuff in Jira.
>>
>> Cheers,
>> Phil
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
>> For additional commands, e-mail: user-help@commons.apache.org
>>
>>

Re: [lang3] Problem with the OSGi metadata: Bundle-SymbolicName / breaking change between 3.7 and 3.8

Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Sep 20, 2018 at 2:33 PM P. Ottlinger <po...@apache.org> wrote:

> Hi,
>
> Am 19.09.2018 um 13:44 schrieb Rob Tompkins:
> >
> >
> >> On Sep 19, 2018, at 4:25 AM, Benedikt Ritter <br...@apache.org>
> wrote:
> >>
> >> ... bringing this to the developers list...
> >>
> >> I think this issue has been caused by this change:
> >>
> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?r1=1833874&r2=1833926
> >
> > Do we roll a 3.8.1?
>
>
> +1
>

The VOTE in already under way...

Gary


>
> Thanks,
> Phil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Re: [lang3] Problem with the OSGi metadata: Bundle-SymbolicName / breaking change between 3.7 and 3.8

Posted by "P. Ottlinger" <po...@apache.org>.
Hi,

Am 19.09.2018 um 13:44 schrieb Rob Tompkins:
> 
> 
>> On Sep 19, 2018, at 4:25 AM, Benedikt Ritter <br...@apache.org> wrote:
>>
>> ... bringing this to the developers list...
>>
>> I think this issue has been caused by this change:
>> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?r1=1833874&r2=1833926
> 
> Do we roll a 3.8.1?


+1

Thanks,
Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [lang3] Problem with the OSGi metadata: Bundle-SymbolicName / breaking change between 3.7 and 3.8

Posted by Benedikt Ritter <br...@apache.org>.
Am Mi., 19. Sep. 2018 um 16:42 Uhr schrieb Rob Tompkins <chtompki@gmail.com
>:

> Do we have a JIRA for this?
>

Yes, it's LANG-1419 and COMMONSSITE-125

Benedikt


>
> > On Sep 19, 2018, at 7:59 AM, Benedikt Ritter <br...@apache.org> wrote:
> >
> > Hi,
> >
> > Am Mi., 19. Sep. 2018 um 13:44 Uhr schrieb Rob Tompkins <
> chtompki@gmail.com <ma...@gmail.com>
> >> :
> >
> >>
> >>
> >>> On Sep 19, 2018, at 4:25 AM, Benedikt Ritter <britter@apache.org
> <ma...@apache.org>> wrote:
> >>>
> >>> ... bringing this to the developers list...
> >>>
> >>> I think this issue has been caused by this change:
> >>>
> >>
> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?r1=1833874&r2=1833926
> <
> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?r1=1833874&r2=1833926
> >
> >>
> >> Do we roll a 3.8.1?
> >>
> >
> > I plan to do so once I've released commons-csv 1.6. We probably need to
> > create 3.8.1 based on the 3.8 release tag because we already introduced
> the
> > Java 8 changes on the master branch and I don't think those changes
> should
> > be included in a patch release.
> >
> > Regards,
> > Benedikt
> >
> >
> >>
> >> -Rob
> >>>
> >>> I don't understand why an update of the commons build plugin had to
> >> change
> >>> the OSGi meta data being generated. Maybe the change
> >>> to commons.osgi.symbolicName was by accident? Can it be reverted?
> >>>
> >>> Regards,
> >>> Benedikt
> >>>
> >>> Am Do., 6. Sep. 2018 um 21:35 Uhr schrieb P. Ottlinger <
> >>> pottlinger@apache.org>:
> >>>
> >>>> Hi,
> >>>>
> >>>> thanks for quick response ...
> >>>>
> >>>>> Am 06.09.2018 um 21:24 schrieb Oliver Heger:
> >>>>> So opening a ticket in Jira would be the correct action to take.
> >>>>
> >>>> https://issues.apache.org/jira/browse/LANG-1419
> >>>>
> >>>> Done :-) Hopefully I didn't miss any important stuff in Jira.
> >>>>
> >>>> Cheers,
> >>>> Phil
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
> >>>> For additional commands, e-mail: user-help@commons.apache.org
> >>>>
> >>>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org <mailto:
> dev-unsubscribe@commons.apache.org>
> >> For additional commands, e-mail: dev-help@commons.apache.org <mailto:
> dev-help@commons.apache.org>
>

Re: [lang3] Problem with the OSGi metadata: Bundle-SymbolicName / breaking change between 3.7 and 3.8

Posted by Rob Tompkins <ch...@gmail.com>.
Do we have a JIRA for this?

> On Sep 19, 2018, at 7:59 AM, Benedikt Ritter <br...@apache.org> wrote:
> 
> Hi,
> 
> Am Mi., 19. Sep. 2018 um 13:44 Uhr schrieb Rob Tompkins <chtompki@gmail.com <ma...@gmail.com>
>> :
> 
>> 
>> 
>>> On Sep 19, 2018, at 4:25 AM, Benedikt Ritter <britter@apache.org <ma...@apache.org>> wrote:
>>> 
>>> ... bringing this to the developers list...
>>> 
>>> I think this issue has been caused by this change:
>>> 
>> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?r1=1833874&r2=1833926 <http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?r1=1833874&r2=1833926>
>> 
>> Do we roll a 3.8.1?
>> 
> 
> I plan to do so once I've released commons-csv 1.6. We probably need to
> create 3.8.1 based on the 3.8 release tag because we already introduced the
> Java 8 changes on the master branch and I don't think those changes should
> be included in a patch release.
> 
> Regards,
> Benedikt
> 
> 
>> 
>> -Rob
>>> 
>>> I don't understand why an update of the commons build plugin had to
>> change
>>> the OSGi meta data being generated. Maybe the change
>>> to commons.osgi.symbolicName was by accident? Can it be reverted?
>>> 
>>> Regards,
>>> Benedikt
>>> 
>>> Am Do., 6. Sep. 2018 um 21:35 Uhr schrieb P. Ottlinger <
>>> pottlinger@apache.org>:
>>> 
>>>> Hi,
>>>> 
>>>> thanks for quick response ...
>>>> 
>>>>> Am 06.09.2018 um 21:24 schrieb Oliver Heger:
>>>>> So opening a ticket in Jira would be the correct action to take.
>>>> 
>>>> https://issues.apache.org/jira/browse/LANG-1419
>>>> 
>>>> Done :-) Hopefully I didn't miss any important stuff in Jira.
>>>> 
>>>> Cheers,
>>>> Phil
>>>> 
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: user-help@commons.apache.org
>>>> 
>>>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org <ma...@commons.apache.org>
>> For additional commands, e-mail: dev-help@commons.apache.org <ma...@commons.apache.org>

Re: [lang3] Problem with the OSGi metadata: Bundle-SymbolicName / breaking change between 3.7 and 3.8

Posted by Benedikt Ritter <br...@apache.org>.
Hi,

Am Mi., 19. Sep. 2018 um 13:44 Uhr schrieb Rob Tompkins <chtompki@gmail.com
>:

>
>
> > On Sep 19, 2018, at 4:25 AM, Benedikt Ritter <br...@apache.org> wrote:
> >
> > ... bringing this to the developers list...
> >
> > I think this issue has been caused by this change:
> >
> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?r1=1833874&r2=1833926
>
> Do we roll a 3.8.1?
>

I plan to do so once I've released commons-csv 1.6. We probably need to
create 3.8.1 based on the 3.8 release tag because we already introduced the
Java 8 changes on the master branch and I don't think those changes should
be included in a patch release.

Regards,
Benedikt


>
> -Rob
> >
> > I don't understand why an update of the commons build plugin had to
> change
> > the OSGi meta data being generated. Maybe the change
> > to commons.osgi.symbolicName was by accident? Can it be reverted?
> >
> > Regards,
> > Benedikt
> >
> > Am Do., 6. Sep. 2018 um 21:35 Uhr schrieb P. Ottlinger <
> > pottlinger@apache.org>:
> >
> >> Hi,
> >>
> >> thanks for quick response ...
> >>
> >>> Am 06.09.2018 um 21:24 schrieb Oliver Heger:
> >>> So opening a ticket in Jira would be the correct action to take.
> >>
> >> https://issues.apache.org/jira/browse/LANG-1419
> >>
> >> Done :-) Hopefully I didn't miss any important stuff in Jira.
> >>
> >> Cheers,
> >> Phil
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: user-help@commons.apache.org
> >>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Re: [lang3] Problem with the OSGi metadata: Bundle-SymbolicName / breaking change between 3.7 and 3.8

Posted by Rob Tompkins <ch...@gmail.com>.

> On Sep 19, 2018, at 4:25 AM, Benedikt Ritter <br...@apache.org> wrote:
> 
> ... bringing this to the developers list...
> 
> I think this issue has been caused by this change:
> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?r1=1833874&r2=1833926

Do we roll a 3.8.1?

-Rob
> 
> I don't understand why an update of the commons build plugin had to change
> the OSGi meta data being generated. Maybe the change
> to commons.osgi.symbolicName was by accident? Can it be reverted?
> 
> Regards,
> Benedikt
> 
> Am Do., 6. Sep. 2018 um 21:35 Uhr schrieb P. Ottlinger <
> pottlinger@apache.org>:
> 
>> Hi,
>> 
>> thanks for quick response ...
>> 
>>> Am 06.09.2018 um 21:24 schrieb Oliver Heger:
>>> So opening a ticket in Jira would be the correct action to take.
>> 
>> https://issues.apache.org/jira/browse/LANG-1419
>> 
>> Done :-) Hopefully I didn't miss any important stuff in Jira.
>> 
>> Cheers,
>> Phil
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
>> For additional commands, e-mail: user-help@commons.apache.org
>> 
>> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [lang3] Problem with the OSGi metadata: Bundle-SymbolicName / breaking change between 3.7 and 3.8

Posted by Benedikt Ritter <br...@apache.org>.
... bringing this to the developers list...

I think this issue has been caused by this change:
http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?r1=1833874&r2=1833926

I don't understand why an update of the commons build plugin had to change
the OSGi meta data being generated. Maybe the change
to commons.osgi.symbolicName was by accident? Can it be reverted?

Regards,
Benedikt

Am Do., 6. Sep. 2018 um 21:35 Uhr schrieb P. Ottlinger <
pottlinger@apache.org>:

> Hi,
>
> thanks for quick response ...
>
> Am 06.09.2018 um 21:24 schrieb Oliver Heger:
> > So opening a ticket in Jira would be the correct action to take.
>
> https://issues.apache.org/jira/browse/LANG-1419
>
> Done :-) Hopefully I didn't miss any important stuff in Jira.
>
> Cheers,
> Phil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
> For additional commands, e-mail: user-help@commons.apache.org
>
>

Re: [lang3] Problem with the OSGi metadata: Bundle-SymbolicName / breaking change between 3.7 and 3.8

Posted by "P. Ottlinger" <po...@apache.org>.
Hi,

thanks for quick response ...

Am 06.09.2018 um 21:24 schrieb Oliver Heger:
> So opening a ticket in Jira would be the correct action to take.

https://issues.apache.org/jira/browse/LANG-1419

Done :-) Hopefully I didn't miss any important stuff in Jira.

Cheers,
Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
For additional commands, e-mail: user-help@commons.apache.org


Re: [lang3] Problem with the OSGi metadata: Bundle-SymbolicName / breaking change between 3.7 and 3.8

Posted by Oliver Heger <ol...@oliver-heger.de>.
Hi Phil,

as you already assume, this change in the OSGi meta data was caused by
changes in the build process and not intended.

So opening a ticket in Jira would be the correct action to take.

Thank you for reporting!
Oliver

Am 06.09.2018 um 20:49 schrieb P. Ottlinger:
> Hi,
> 
> I've just stumbled upon a problem that prevents me from updating from
> 3.7 to 3.8 in an OSGi context.
> 
> Although the release has just been a patch one, the bundle's symbolic
> name changed
> from "Bundle-SymbolicName org.apache.commons.lang3" in 3.7.0
> to "Bundle-SymbolicName org.apache.commons.commons-lang3" in 3.8.0.
> 
> That makes it impossible to do a drop-in update, as it is a breaking change.
> 
> Is that change an error in 3.8.0 or a wanted one that could be
> communicated more directly to downstream users?
> 
> May I file a bugticket in the LANG-Jira for it? I assume there has been
> a hickup when building the OSGi release JAR and the change was not intended.
> 
> Thanks,
> Phil
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
> For additional commands, e-mail: user-help@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
For additional commands, e-mail: user-help@commons.apache.org