You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/05/18 14:42:34 UTC

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5578: [Relay][Refactor][std::string --> String] Relay updated with String

tqchen commented on a change in pull request #5578:
URL: https://github.com/apache/incubator-tvm/pull/5578#discussion_r426677508



##########
File path: include/tvm/relay/base.h
##########
@@ -93,7 +93,7 @@ class IdNode : public Object {
    *  this only acts as a hint to the user,
    *  and is not used for equality.
    */
-  std::string name_hint;
+  String name_hint;

Review comment:
       per https://github.com/apache/incubator-tvm/issues/5490#issuecomment-624408382 every update to the IRNode object needs to have a backward compatible update code




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org