You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2018/09/29 12:08:00 UTC
[jira] [Commented] (HBASE-21255) Refactor TablePermission into
three classes (Global, Namespace, Table)
[ https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632972#comment-16632972 ]
Hadoop QA commented on HBASE-21255:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 7 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 32s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 25s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 35s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 19s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 44s{color} | {color:red} hbase-client generated 4 new + 99 unchanged - 4 fixed = 103 total (was 103) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 20s{color} | {color:red} hbase-server generated 5 new + 183 unchanged - 5 fixed = 188 total (was 188) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 38s{color} | {color:red} hbase-client: The patch generated 16 new + 80 unchanged - 29 fixed = 96 total (was 109) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 20s{color} | {color:red} hbase-server: The patch generated 14 new + 105 unchanged - 50 fixed = 119 total (was 155) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 47s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 10m 48s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 5s{color} | {color:red} hbase-client generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 25s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 25s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 44s{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}124m 28s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 24s{color} | {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 24s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}190m 50s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-client |
| | Unchecked/unconfirmed cast from org.apache.hadoop.hbase.security.access.Permission to org.apache.hadoop.hbase.security.access.NamespacePermission in org.apache.hadoop.hbase.security.access.AccessControlUtil.toPermission(Permission) At AccessControlUtil.java:org.apache.hadoop.hbase.security.access.NamespacePermission in org.apache.hadoop.hbase.security.access.AccessControlUtil.toPermission(Permission) At AccessControlUtil.java:[line 336] |
| | Unchecked/unconfirmed cast from org.apache.hadoop.hbase.security.access.Permission to org.apache.hadoop.hbase.security.access.TablePermission in org.apache.hadoop.hbase.security.access.AccessControlUtil.toPermission(Permission) At AccessControlUtil.java:org.apache.hadoop.hbase.security.access.TablePermission in org.apache.hadoop.hbase.security.access.AccessControlUtil.toPermission(Permission) At AccessControlUtil.java:[line 351] |
| | Unchecked/unconfirmed cast from org.apache.hadoop.hbase.security.access.Permission to org.apache.hadoop.hbase.security.access.NamespacePermission in org.apache.hadoop.hbase.security.access.ShadedAccessControlUtil.toPermission(Permission) At ShadedAccessControlUtil.java:org.apache.hadoop.hbase.security.access.NamespacePermission in org.apache.hadoop.hbase.security.access.ShadedAccessControlUtil.toPermission(Permission) At ShadedAccessControlUtil.java:[line 173] |
| | Unchecked/unconfirmed cast from org.apache.hadoop.hbase.security.access.Permission to org.apache.hadoop.hbase.security.access.TablePermission in org.apache.hadoop.hbase.security.access.ShadedAccessControlUtil.toPermission(Permission) At ShadedAccessControlUtil.java:org.apache.hadoop.hbase.security.access.TablePermission in org.apache.hadoop.hbase.security.access.ShadedAccessControlUtil.toPermission(Permission) At ShadedAccessControlUtil.java:[line 189] |
| Failed junit tests | hadoop.hbase.client.TestScan |
| | hadoop.hbase.client.TestGet |
| | hadoop.hbase.security.access.TestTablePermissions |
| | hadoop.hbase.security.access.TestRpcAccessChecks |
| | hadoop.hbase.security.access.TestNamespaceCommands |
| | hadoop.hbase.security.access.TestCellACLWithMultipleVersions |
| | hadoop.hbase.security.access.TestScanEarlyTermination |
| | hadoop.hbase.security.access.TestZKPermissionWatcher |
| | hadoop.hbase.security.access.TestWithDisabledAuthorization |
| | hadoop.hbase.security.access.TestCellACLs |
| | hadoop.hbase.client.TestSnapshotWithAcl |
| | hadoop.hbase.security.access.TestAccessController3 |
| | hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL |
| | hadoop.hbase.security.access.TestAccessControlFilter |
| | hadoop.hbase.rsgroup.TestRSGroupsWithACL |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21255 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12941814/HBASE-21225.master.001.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 68ef46379b87 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
| git revision | master / fdbaa4c3f0 |
| maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/14540/artifact/patchprocess/diff-compile-javac-hbase-client.txt |
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/14540/artifact/patchprocess/diff-compile-javac-hbase-server.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/14540/artifact/patchprocess/diff-checkstyle-hbase-client.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/14540/artifact/patchprocess/diff-checkstyle-hbase-server.txt |
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/14540/artifact/patchprocess/new-findbugs-hbase-client.html |
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/14540/artifact/patchprocess/patch-unit-hbase-client.txt |
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/14540/artifact/patchprocess/patch-unit-hbase-server.txt |
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/14540/artifact/patchprocess/patch-unit-hbase-rsgroup.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/14540/testReport/ |
| Max. process+thread count | 5112 (vs. ulimit of 10000) |
| modules | C: hbase-common hbase-client hbase-server hbase-rsgroup U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/14540/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Refactor TablePermission into three classes (Global, Namespace, Table)
> ----------------------------------------------------------------------
>
> Key: HBASE-21255
> URL: https://issues.apache.org/jira/browse/HBASE-21255
> Project: HBase
> Issue Type: Improvement
> Reporter: Reid Chan
> Assignee: Reid Chan
> Priority: Major
> Attachments: HBASE-21225.master.001.patch
>
>
> A TODO in {{TablePermission.java}}
> {code}
> //TODO refactor this class
> //we need to refacting this into three classes (Global, Table, Namespace)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)