[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #7283: [improvement](compaction)(tablet repair) Add missing rowsets in compaction status url and support force dropping redundant replica

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on a change in pull request #7283:
URL: https://github.com/apache/incubator-doris/pull/7283#discussion_r761733397



##########
File path: docs/zh-CN/administrator-guide/http-actions/compaction-action.md
##########
@@ -84,6 +84,7 @@ curl -X GET http://be_host:webserver_port/api/compaction/show?tablet_id=xxxx\&sc
         "[50-50] 0 DELETE NONOVERLAPPING 574.00 B",
         "[51-51] 5 DATA OVERLAPPING 574.00 B"
     ],
+    "missing_rowsets": [],

Review comment:
       如果 compaction 的时候发现有 missing 的row set 那数据不就直接错误了嘛？
   那还有必要知道丢了哪些版本嘛？直接标记tablet error？

##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/Config.java
##########
@@ -1544,4 +1544,15 @@
      */
     @ConfField(mutable = true, masterOnly = true)
     public static boolean disable_tablet_scheduler = false;
+
+	/*

Review comment:
       code format

##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/Config.java
##########
@@ -1544,4 +1544,15 @@
      */
     @ConfField(mutable = true, masterOnly = true)
     public static boolean disable_tablet_scheduler = false;
+
+	/*
+     * When doing clone or repair tablet task, there may be replica is REDUNDANT state, which
+     * should be dropped later. But there are be loading task on these replicas, so the default strategy
+     * is to wait until the loading task finished before dropping them.
+     * But the default strategy may takes very long time to handle these redundant replicas.
+     * So we can set this config to true to not wait any loading task.
+     * Set this config to true may cause loading task failed, but will speed up the process of tablet balance and repair.
+     */
+    @ConfField(mutable = true, masterOnly = true)
+    public static boolean force_drop_redundant_replica = false;

Review comment:
       ```suggestion
       public static boolean enable_force_drop_redundant_replica = false;
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org