You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martijn Dashorst (JIRA)" <ji...@apache.org> on 2011/02/28 15:55:36 UTC

[jira] Assigned: (WICKET-3485) Link tries to construct the URL when the link is disabled

     [ https://issues.apache.org/jira/browse/WICKET-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martijn Dashorst reassigned WICKET-3485:
----------------------------------------

    Assignee: Martijn Dashorst

> Link tries to construct the URL when the link is disabled
> ---------------------------------------------------------
>
>                 Key: WICKET-3485
>                 URL: https://issues.apache.org/jira/browse/WICKET-3485
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.4.15
>            Reporter: Emond Papegaaij
>            Assignee: Martijn Dashorst
>            Priority: Minor
>
> This piece of code (Link.onComponentTag) tries to construct the URL for a Link, even when it is disabled:
> 	CharSequence url = getURL();
> 	url = appendAnchor(tag, url);
> 	if (!isLinkEnabled())
> 		disableLink(tag);
> 	else
> 		{ use url }
> getURL fails for us, because we did not expect it to be called for a disabled link. The constructed url is never used. Can the getURL and appendAnchor be moved inside the else?

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira