[GitHub] [nifi] exceptionfactory commented on a change in pull request #5210: NIFI-8768 Added toLocalDate() for convertType() handling of DATE fields

[GitBox <gi...@apache.org>]

exceptionfactory commented on a change in pull request #5210:
URL: https://github.com/apache/nifi/pull/5210#discussion_r668902144



##########
File path: nifi-commons/nifi-record/src/test/java/org/apache/nifi/serialization/record/TestDataTypeUtils.java
##########
@@ -923,23 +939,73 @@ public void testConvertDateToUTC() {
         assertEquals(0, zdt.getNano());
     }
 
+    /**
+     * Convert String to java.sql.Date using implicit default DateFormat with GMT Time Zone
+     *
+     * Running this method on a system with a time zone other than GMT should return the same year-month-day
+     */
     @Test
-    public void testConvertDateToLocalTZ() {
-        int year = 2021;
-        int month = 1;
-        int dayOfMonth = 25;
+    public void testConvertTypeStringToDateDefaultTimeZoneFormat() {

Review comment:
       I thought about that approach, and there is one existing unit test method that works as you described. However, since the GitHub automated builds run with three different time zone settings, that seems to be a better way to cover a variety of system configurations.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org