[GitHub] [madlib] orhankislal commented on a change in pull request #440: DL: Update training_preprocessor_dl to use bytea

[GitBox <gi...@apache.org>]

orhankislal commented on a change in pull request #440: DL: Update training_preprocessor_dl to use bytea
URL: https://github.com/apache/madlib/pull/440#discussion_r322969987
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/input_data_preprocessor.py_in
 ##########
 @@ -176,15 +176,25 @@ class InputDataPreprocessorDL(object):
             distributed_by_clause = ''
         else:
             distributed_by_clause= ' DISTRIBUTED BY (buffer_id) '
+        dep_shape_col = add_postfix(
+            MINIBATCH_OUTPUT_DEPENDENT_COLNAME_DL, "_shape")
+        ind_shape_col = add_postfix(
+            MINIBATCH_OUTPUT_INDEPENDENT_COLNAME_DL, "_shape")
         sql = """
             CREATE TABLE {self.output_table} AS
-            SELECT * FROM
+            SELECT {self.schema_madlib}.convert_array_to_bytea({x}) AS {x},
+                   {self.schema_madlib}.convert_array_to_bytea({y}) AS {y},
+                   array_dims({x}) AS {ind_shape_col},
+                   array_dims({y}) AS {dep_shape_col},
 
 Review comment:
   It definitely is a more natural way of storing it. We can construct a sql query dynamically to accommodate any shape of input (instead of just 3D).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services