[GitHub] kkirby opened a new pull request #539: Hotfix/fix dest overwrite

[GitBox <gi...@apache.org>]

kkirby opened a new pull request #539: Hotfix/fix dest overwrite
URL: https://github.com/apache/cordova-android/pull/539
 
 
   ### Platforms affected
   
   Android
   
   ### What does this PR do?
   
   Makes sure that we don't overwrite the `target-dir` of a `source-file` if the project base is android studio and the `target-dir` is the proper install path and doesn't need to be re-mapped.
   
   ### What testing has been done on this change?
   
   I've added a new unit test, confirmed the problem exists, fixed the issue and re-ran the tests.
   
   ### Checklist
   - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [x] Added automated test coverage as appropriate for this change.
   
   ### More details
   
   Latest release (7.1.2) breaks our build. After investigation it appears that `source-file.install` handler was updated to extract the functionality of path remapping for android studio. However, if the path doesn't need to be remapped, the function returns undefined, thus updating dest to be undefined.
   
   #### Related lines
   https://github.com/apache/cordova-android/compare/7a97fd7...7.1.2#diff-4f73e5f70cec312ae82aa7d023e3c88bR320
   https://github.com/apache/cordova-android/compare/7a97fd7...7.1.2#diff-4f73e5f70cec312ae82aa7d023e3c88bR50
   
   #### Resolution
   
   Just change line 50 to ` studioPathRemap(obj) || dest`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org