You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/02 15:13:53 UTC
[GitHub] [shardingsphere-elasticjob] terrymanu opened a new issue #1537: Redesign SPI factory to make them into one class
terrymanu opened a new issue #1537:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1537
The current factory using SPI are separate into multiple classes.
It is better redesign and abstract them into one class.
The SPI factory class are:
- JobItemExecutorFactory
- JobShardingStrategyFactory
- JobExecutorServiceHandlerFactory
- JobErrorHandlerFactory
- ElasticJobListenerFactory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu closed issue #1537: Redesign SPI factory to make them into one class
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #1537:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1537
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] wwj-go commented on issue #1537: Redesign SPI factory to make them into one class
Posted by GitBox <gi...@apache.org>.
wwj-go commented on issue #1537:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1537#issuecomment-703048097
@terrymanu hi，I am very interested in this task, could you assign it to me ？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] wwj-go commented on issue #1537: Redesign SPI factory to make them into one class
Posted by GitBox <gi...@apache.org>.
wwj-go commented on issue #1537:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1537#issuecomment-705293202
hi @Technoboy- ，I'm sorry to reply so late. In the past few days, I have read the code related to this issues, and have done a lot of thinking and trying. Finally, I found that if you want to solve this problem elegantly, it is best to implement your own SPI loading mechanism to replace java The native SPI mechanism, refer to the practice of [dubbo ](https://github.com/apache/dubbo), I have implemented it, and related issue is [here ](https://github.com/apache/shardingsphere-elasticjob/issues/1546), Later I will submit a new code that implements the SPI mechanism. After the reconstruction of the SPI mechanism is completed, I will continue to complete this problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org