You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "zhongqiangczq (via GitHub)" <gi...@apache.org> on 2023/06/28 02:49:59 UTC

[GitHub] [incubator-celeborn] zhongqiangczq opened a new pull request, #1635: [CELEBORN-724] Fix the compatibility of HeartbeatFromApplicationRespo…

zhongqiangczq opened a new pull request, #1635:
URL: https://github.com/apache/incubator-celeborn/pull/1635

   …nse with lower versions
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1635: [CELEBORN-724] Fix the compatibility of HeartbeatFromApplicationRespo…

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1635:
URL: https://github.com/apache/incubator-celeborn/pull/1635#discussion_r1244635357


##########
common/src/main/proto/TransportMessages.proto:
##########
@@ -281,6 +281,7 @@ message PbHeartbeatFromApplication {
   int64 fileCount = 3 ;
   string requestId = 4;
   repeated PbWorkerInfo needCheckedWorkerList = 5;
+  bool reply = 6;

Review Comment:
   shouldResponse?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #1635: [CELEBORN-724] Fix the compatibility of HeartbeatFromApplicationRespo…

Posted by "zhongqiangczq (via GitHub)" <gi...@apache.org>.
zhongqiangczq commented on code in PR #1635:
URL: https://github.com/apache/incubator-celeborn/pull/1635#discussion_r1244769680


##########
common/src/main/proto/TransportMessages.proto:
##########
@@ -281,6 +281,7 @@ message PbHeartbeatFromApplication {
   int64 fileCount = 3 ;
   string requestId = 4;
   repeated PbWorkerInfo needCheckedWorkerList = 5;
+  bool reply = 6;

Review Comment:
   ok, fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1635: [CELEBORN-724] Fix the compatibility of HeartbeatFromApplicationRespo…

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1635:
URL: https://github.com/apache/incubator-celeborn/pull/1635#issuecomment-1610651593

   > Have you tested client side is 0.3.0 and server side is 0.2.1?
   
   Seems only print a error message
   ```
    logError("Error while send heartbeat", t)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] pan3793 commented on pull request #1635: [CELEBORN-724] Fix the compatibility of HeartbeatFromApplicationRespo…

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1635:
URL: https://github.com/apache/incubator-celeborn/pull/1635#issuecomment-1610872410

   Could you update migration guide? The previous "ignore" tips is useless now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] zhongqiangczq commented on pull request #1635: [CELEBORN-724] Fix the compatibility of HeartbeatFromApplicationRespo…

Posted by "zhongqiangczq (via GitHub)" <gi...@apache.org>.
zhongqiangczq commented on PR #1635:
URL: https://github.com/apache/incubator-celeborn/pull/1635#issuecomment-1610896564

   > Could you update migration guide? The previous "ignore" tips is useless now
   
   i have delete those tips and add an tip that client 0.3.0 is not compatible with server 0.2.x.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #1635: [CELEBORN-724] Fix the compatibility of HeartbeatFromApplicationRespo…

Posted by "zhongqiangczq (via GitHub)" <gi...@apache.org>.
zhongqiangczq commented on code in PR #1635:
URL: https://github.com/apache/incubator-celeborn/pull/1635#discussion_r1244647905


##########
common/src/main/proto/TransportMessages.proto:
##########
@@ -281,6 +281,7 @@ message PbHeartbeatFromApplication {
   int64 fileCount = 3 ;
   string requestId = 4;
   repeated PbWorkerInfo needCheckedWorkerList = 5;
+  bool reply = 6;

Review Comment:
   ok, it is renamed to shouldResponseMoreInfos



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] zhongqiangczq commented on pull request #1635: [CELEBORN-724] Fix the compatibility of HeartbeatFromApplicationRespo…

Posted by "zhongqiangczq (via GitHub)" <gi...@apache.org>.
zhongqiangczq commented on PR #1635:
URL: https://github.com/apache/incubator-celeborn/pull/1635#issuecomment-1610666416

   > > Have you tested client side is 0.3.0 and server side is 0.2.1?
   > 
   > Seems only print a error message
   > 
   > ```
   >  logError("Error while send heartbeat", t)
   > ```
   yes, it will print the error as you says. The error is caused by  timeout exception or  ClassCastException


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] pan3793 commented on pull request #1635: [CELEBORN-724] Fix the compatibility of HeartbeatFromApplicationRespo…

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1635:
URL: https://github.com/apache/incubator-celeborn/pull/1635#issuecomment-1610600350

   This approach looks clean, please fill in the PR description, and we can also delete the migration guide part


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1635: [CELEBORN-724] Fix the compatibility of HeartbeatFromApplicationRespo…

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1635:
URL: https://github.com/apache/incubator-celeborn/pull/1635#discussion_r1244648369


##########
common/src/main/proto/TransportMessages.proto:
##########
@@ -281,6 +281,7 @@ message PbHeartbeatFromApplication {
   int64 fileCount = 3 ;
   string requestId = 4;
   repeated PbWorkerInfo needCheckedWorkerList = 5;
+  bool reply = 6;

Review Comment:
   I prefer to `shouldResponse`, `shouldResponseMoreInfos` is redundant



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] pan3793 closed pull request #1635: [CELEBORN-724] Fix the compatibility of HeartbeatFromApplicationRespo…

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #1635: [CELEBORN-724] Fix the compatibility of HeartbeatFromApplicationRespo…
URL: https://github.com/apache/incubator-celeborn/pull/1635


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1635: [CELEBORN-724] Fix the compatibility of HeartbeatFromApplicationRespo…

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1635:
URL: https://github.com/apache/incubator-celeborn/pull/1635#issuecomment-1610650180

   Have you tested client side is 0.3.0 and server side is 0.2.1?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] pan3793 commented on pull request #1635: [CELEBORN-724] Fix the compatibility of HeartbeatFromApplicationRespo…

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1635:
URL: https://github.com/apache/incubator-celeborn/pull/1635#issuecomment-1610878951

   BTW, I suppose at least the dual compatibility should be guaranteed before 1.0. e.g.
   
   0.2 client compatible with [0.2, 0.3] server
   0.3 client compatible with [0.2, 0.4] server
   0.4 client compatible with [0.3, 0.5] server
   
   This reduces the users' upgrading effort and still allows developers to rapidly introduce breaking changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] pan3793 commented on pull request #1635: [CELEBORN-724] Fix the compatibility of HeartbeatFromApplicationRespo…

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1635:
URL: https://github.com/apache/incubator-celeborn/pull/1635#issuecomment-1610957807

   Thanks, merged to main/0.3 (FYI, I update the content of migration guide)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1635: [CELEBORN-724] Fix the compatibility of HeartbeatFromApplicationRespo…

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1635:
URL: https://github.com/apache/incubator-celeborn/pull/1635#issuecomment-1610604762

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1635?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#1635](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1635?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (861bb41) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/1753556565e73fa74dd9f3d7722ec09ac0a5b476?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1753556) will **increase** coverage by `0.22%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##             main    #1635      +/-   ##
   ==========================================
   + Coverage   45.91%   46.13%   +0.22%     
   ==========================================
     Files         159      161       +2     
     Lines        9924     9994      +70     
     Branches      970      973       +3     
   ==========================================
   + Hits         4556     4610      +54     
   - Misses       5068     5084      +16     
     Partials      300      300              
   ```
   
   
   | [Impacted Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...born/common/protocol/message/ControlMessages.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3Byb3RvY29sL21lc3NhZ2UvQ29udHJvbE1lc3NhZ2VzLnNjYWxh) | `1.38% <0.00%> (-0.01%)` | :arrow_down: |
   
   ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1635/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org