You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "ttttttz (Code Review)" <ge...@cloudera.org> on 2024/08/25 08:50:06 UTC
[Impala-ASF-CR] IMPALA-: Change USE APACHE HIVE to USE APACHE HIVE 3
ttttttz has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21724
Change subject: IMPALA-: Change USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
IMPALA-: Change USE_APACHE_HIVE to USE_APACHE_HIVE_3
After IMPALA-10870, when the environment variable USE_APACHE_HIVE
is set to true the bootstrap_toolchain script downloads Apache
Hive 3.1.x tarballs and extracts it in the toolchain directory. To
better distinguish from Apache Hive 2.x in the future, change
USE_APACHE_HIVE to USE_APACHE_HIVE_3.
Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M testdata/bin/generate-schema-statements.py
M testdata/bin/load_nested.py
M testdata/bin/patch_hive.sh
M tests/common/environ.py
M tests/util/test_file_parser.py
10 files changed, 32 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/21724/1
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 1
Gerrit-Owner: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-: Change USE APACHE HIVE to USE APACHE HIVE 3
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21724
to look at the new patch set (#2).
Change subject: IMPALA-: Change USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
IMPALA-: Change USE_APACHE_HIVE to USE_APACHE_HIVE_3
After IMPALA-10870, when the environment variable USE_APACHE_HIVE
is set to true the bootstrap_toolchain script downloads Apache
Hive 3.1.x tarballs and extracts it in the toolchain directory. To
better distinguish from Apache Hive 2.x in the future, change
USE_APACHE_HIVE to USE_APACHE_HIVE_3.
Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
---
M README-build.md
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/load_nested.py
M testdata/bin/patch_hive.sh
M tests/common/environ.py
M tests/util/test_file_parser.py
12 files changed, 36 insertions(+), 37 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/21724/2
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 2
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 13:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12171/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 13
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 14 Jul 2025 02:40:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21724
to look at the new patch set (#20).
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
When the environment variable USE_APACHE_HIVE is set to true, build
Impala for adapting to Apache Hive 3.x. In order to better distinguish it
from Apache Hive 2.x later, rename USE_APACHE_HIVE to USE_APACHE_HIVE_3.
Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
---
M README-build.md
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
M fe/src/test/resources/hive-site.xml.py
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/load_nested.py
M testdata/bin/patch_hive.sh
M tests/common/environ.py
M tests/util/test_file_parser.py
14 files changed, 35 insertions(+), 35 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/21724/20
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 20
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
When the environment variable USE_APACHE_HIVE is set to true, build
Impala for adapting to Apache Hive 3.x. In order to better distinguish it
from Apache Hive 2.x later, rename USE_APACHE_HIVE to USE_APACHE_HIVE_3.
Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
---
M README-build.md
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/load_nested.py
M testdata/bin/patch_hive.sh
M tests/common/environ.py
M tests/util/test_file_parser.py
13 files changed, 31 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/21724/11
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 11
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
When the environment variable USE_APACHE_HIVE is set to true, build
Impala for adapting to Apache Hive 3.x. In order to better distinguish it
from Apache Hive 2.x later, rename USE_APACHE_HIVE to USE_APACHE_HIVE_3.
Additionally, to facilitate referencing different versions of the Hive
MetastoreShim, the major version of Hive has been added to the environment
variable IMPALA_HIVE_DIST_TYPE.
Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Reviewed-on: http://gerrit.cloudera.org:8080/21724
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M README-build.md
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
M fe/src/test/resources/hive-site.xml.py
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/load_nested.py
M testdata/bin/patch_hive.sh
M tests/common/environ.py
M tests/util/test_file_parser.py
14 files changed, 36 insertions(+), 36 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 35
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 33: Code-Review+2
LGTM. Carrying Riza's +1.
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 33
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 08:38:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 19:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12275/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 19
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 07 Aug 2025 02:05:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-: Change USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-: Change USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16788/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 2
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 25 Aug 2024 10:50:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21724
to look at the new patch set (#14).
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
When the environment variable USE_APACHE_HIVE is set to true, build
Impala for adapting to Apache Hive 3.x. In order to better distinguish it
from Apache Hive 2.x later, rename USE_APACHE_HIVE to USE_APACHE_HIVE_3.
Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
---
M README-build.md
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
M fe/src/test/resources/hive-site.xml.py
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/load_nested.py
M testdata/bin/patch_hive.sh
M tests/common/environ.py
M tests/util/test_file_parser.py
14 files changed, 34 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/21724/14
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 14
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 17: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12245/
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 17
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 29 Jul 2025 08:53:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 11:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19592/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 11
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 07:26:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 12:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21724/11/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/21724/11/bin/impala-config.sh@424
PS11, Line 424: # When USE_APACHE_HIVE_3 is set we use the apache hive version to build as well as
> line too long (91 > 90)
Ack
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 12
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 07:13:33 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Pranav Lodha, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21724
to look at the new patch set (#29).
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
When the environment variable USE_APACHE_HIVE is set to true, build
Impala for adapting to Apache Hive 3.x. In order to better distinguish it
from Apache Hive 2.x later, rename USE_APACHE_HIVE to USE_APACHE_HIVE_3.
Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
---
M README-build.md
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
M fe/src/test/resources/hive-site.xml.py
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/load_nested.py
M testdata/bin/patch_hive.sh
M tests/common/environ.py
M tests/util/test_file_parser.py
14 files changed, 37 insertions(+), 37 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/21724/29
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 29
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-: Change USE APACHE HIVE to USE APACHE HIVE 3
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21724
to look at the new patch set (#3).
Change subject: IMPALA-: Change USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
IMPALA-: Change USE_APACHE_HIVE to USE_APACHE_HIVE_3
After IMPALA-10870, when the environment variable USE_APACHE_HIVE
is set to true the bootstrap_toolchain script downloads Apache
Hive 3.1.x tarballs and extracts it in the toolchain directory. To
better distinguish from Apache Hive 2.x in the future, change
USE_APACHE_HIVE to USE_APACHE_HIVE_3.
Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
---
M README-build.md
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/load_nested.py
M testdata/bin/patch_hive.sh
M tests/common/environ.py
M tests/util/test_file_parser.py
12 files changed, 37 insertions(+), 38 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/21724/3
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 3
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 11:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21724/11/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/21724/11/bin/impala-config.sh@424
PS11, Line 424: # When USE_APACHE_HIVE_3 is set we use the apache hive version to build as well as deploy
line too long (91 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 11
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 07:04:33 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 17: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 17
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 29 Jul 2025 02:36:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 15: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 15
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 03:18:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 24:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20321/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 24
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 31 Aug 2025 16:57:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 13: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12171/
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 13
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 14 Jul 2025 04:36:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21724
to look at the new patch set (#18).
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
When the environment variable USE_APACHE_HIVE is set to true, build
Impala for adapting to Apache Hive 3.x. In order to better distinguish it
from Apache Hive 2.x later, rename USE_APACHE_HIVE to USE_APACHE_HIVE_3.
Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
---
M README-build.md
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
M fe/src/test/resources/hive-site.xml.py
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/load_nested.py
M testdata/bin/patch_hive.sh
M tests/common/environ.py
M tests/util/test_file_parser.py
14 files changed, 34 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/21724/18
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 18
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 16:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12231/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 16
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 24 Jul 2025 06:43:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 17:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12245/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 17
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 29 Jul 2025 02:36:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 15:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12217/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 15
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 03:18:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 29:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/20862/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 29
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 10 Nov 2025 12:56:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-: Change USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-: Change USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16789/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 3
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 25 Aug 2024 10:55:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 14:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12214/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 14
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 21 Jul 2025 09:41:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 19: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12275/
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 19
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 07 Aug 2025 07:47:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 15: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12217/
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 15
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 09:23:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 30:
(3 comments)
Hi, Pranav Lodha! Thanks for your review!
http://gerrit.cloudera.org:8080/#/c/21724/29/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/21724/29/bin/impala-config.sh@426
PS29, Line 426:
> If someone uses USE_APACHE_HIVE=true, do we wanna have a fallback with a wa
Hi! I think it would be better to specify the major version of hive in the environment variables.
http://gerrit.cloudera.org:8080/#/c/21724/29/bin/impala-config.sh@446
PS29, Line 446: hive-3
> nit: Shouldn't this be hive-3.x?
At the build time, based on the environment variable IMPALA_HIVE_DIST_TYPE one of the two shims is added to as source using the fe/pom.xml build plugin. It is clearer to retain only the information of the major version.
http://gerrit.cloudera.org:8080/#/c/21724/29/common/function-registry/CMakeLists.txt
File common/function-registry/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/21724/29/common/function-registry/CMakeLists.txt@64
PS29, Line 64: $
> nit: remove space
Done
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 30
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 13:03:17 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Pranav Lodha (Code Review)" <ge...@cloudera.org>.
Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 29:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/21724/29/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/21724/29/bin/impala-config.sh@426
PS29, Line 426:
If someone uses USE_APACHE_HIVE=true, do we wanna have a fallback with a warning in order to prevent build failures?
http://gerrit.cloudera.org:8080/#/c/21724/29/bin/impala-config.sh@446
PS29, Line 446: hive-3
nit: Shouldn't this be hive-3.x?
http://gerrit.cloudera.org:8080/#/c/21724/29/common/function-registry/CMakeLists.txt
File common/function-registry/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/21724/29/common/function-registry/CMakeLists.txt@64
PS29, Line 64:
nit: remove space
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 29
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 02:52:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 18:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20061/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 18
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 06 Aug 2025 17:22:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Pranav Lodha, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21724
to look at the new patch set (#32).
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
When the environment variable USE_APACHE_HIVE is set to true, build
Impala for adapting to Apache Hive 3.x. In order to better distinguish it
from Apache Hive 2.x later, rename USE_APACHE_HIVE to USE_APACHE_HIVE_3.
Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
---
M README-build.md
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
M fe/src/test/resources/hive-site.xml.py
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/load_nested.py
M testdata/bin/patch_hive.sh
M tests/common/environ.py
M tests/util/test_file_parser.py
14 files changed, 36 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/21724/32
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 32
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 30:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20872/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 30
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 13:15:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-: Change USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-: Change USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16787/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 1
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 25 Aug 2024 09:21:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 14: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12214/
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 14
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 21 Jul 2025 15:45:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 23: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 23
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 07 Aug 2025 15:50:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 12: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 12
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 03 Jul 2025 07:13:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-: Change USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-: Change USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 1:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python2 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with virtualenv installed.
http://gerrit.cloudera.org:8080/#/c/21724/1/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/21724/1/bin/impala-config.sh@395
PS1, Line 395: # When USE_APACHE_HIVE_3 is set we use the apache hive version to build as well as deploy
line too long (91 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 1
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 25 Aug 2024 08:51:16 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 14: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 14
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 21 Jul 2025 09:40:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 16: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 16
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 24 Jul 2025 06:43:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 22:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20073/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 22
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 07 Aug 2025 10:14:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21724
to look at the new patch set (#22).
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
When the environment variable USE_APACHE_HIVE is set to true, build
Impala for adapting to Apache Hive 3.x. In order to better distinguish it
from Apache Hive 2.x later, rename USE_APACHE_HIVE to USE_APACHE_HIVE_3.
Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
---
M README-build.md
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
M fe/src/test/resources/hive-site.xml.py
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/load_nested.py
M testdata/bin/patch_hive.sh
M tests/common/environ.py
M tests/util/test_file_parser.py
14 files changed, 36 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/21724/22
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 22
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Zihao Ye (Code Review)" <ge...@cloudera.org>.
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 12
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 14 Jul 2025 02:39:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 34: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 34
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 13:38:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21724
to look at the new patch set (#12).
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
When the environment variable USE_APACHE_HIVE is set to true, build
Impala for adapting to Apache Hive 3.x. In order to better distinguish it
from Apache Hive 2.x later, rename USE_APACHE_HIVE to USE_APACHE_HIVE_3.
Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
---
M README-build.md
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/load_nested.py
M testdata/bin/patch_hive.sh
M tests/common/environ.py
M tests/util/test_file_parser.py
13 files changed, 32 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/21724/12
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 12
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 12:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19593/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 12
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 07:37:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 13: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 13
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 14 Jul 2025 02:40:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 23:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12278/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 23
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 07 Aug 2025 09:46:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 21:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12277/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 21
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 07 Aug 2025 09:06:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 32: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 32
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 16:42:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 34:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12739/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 34
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 08:39:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 20:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20071/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 20
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 07 Aug 2025 09:20:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21724
to look at the new patch set (#24).
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
When the environment variable USE_APACHE_HIVE is set to true, build
Impala for adapting to Apache Hive 3.x. In order to better distinguish it
from Apache Hive 2.x later, rename USE_APACHE_HIVE to USE_APACHE_HIVE_3.
Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
---
M README-build.md
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
M fe/src/test/resources/hive-site.xml.py
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/load_nested.py
M testdata/bin/patch_hive.sh
M tests/common/environ.py
M tests/util/test_file_parser.py
14 files changed, 36 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/21724/24
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 24
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 14:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19927/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 14
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 21 Jul 2025 07:09:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-: Change USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-: Change USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 2:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python2 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with virtualenv installed.
http://gerrit.cloudera.org:8080/#/c/21724/2/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/21724/2/bin/impala-config.sh@408
PS2, Line 408: # When USE_APACHE_HIVE_3 is set we use the apache hive version to build as well as deploy
line too long (91 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 2
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 25 Aug 2024 10:20:01 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Pranav Lodha, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21724
to look at the new patch set (#30).
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
When the environment variable USE_APACHE_HIVE is set to true, build
Impala for adapting to Apache Hive 3.x. In order to better distinguish it
from Apache Hive 2.x later, rename USE_APACHE_HIVE to USE_APACHE_HIVE_3.
Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
---
M README-build.md
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
M fe/src/test/resources/hive-site.xml.py
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/load_nested.py
M testdata/bin/patch_hive.sh
M tests/common/environ.py
M tests/util/test_file_parser.py
14 files changed, 36 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/21724/30
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 30
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Riza Suminto, Zihao Ye, Pranav Lodha, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21724
to look at the new patch set (#33).
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
When the environment variable USE_APACHE_HIVE is set to true, build
Impala for adapting to Apache Hive 3.x. In order to better distinguish it
from Apache Hive 2.x later, rename USE_APACHE_HIVE to USE_APACHE_HIVE_3.
Additionally, to facilitate referencing different versions of the Hive
MetastoreShim, the major version of Hive has been added to the environment
variable IMPALA_HIVE_DIST_TYPE.
Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
---
M README-build.md
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
M fe/src/test/resources/hive-site.xml.py
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/load_nested.py
M testdata/bin/patch_hive.sh
M tests/common/environ.py
M tests/util/test_file_parser.py
14 files changed, 36 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/21724/33
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 33
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-14183: Rename the environment variable USE APACHE HIVE to USE APACHE HIVE 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3
......................................................................
Patch Set 34: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d
Gerrit-Change-Number: 21724
Gerrit-PatchSet: 34
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 08:39:00 +0000
Gerrit-HasComments: No