You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2015/04/09 22:59:13 UTC

[jira] [Commented] (OAK-2736) Oak instance does not close the executors created upon ContentRepository creation

    [ https://issues.apache.org/jira/browse/OAK-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14488266#comment-14488266 ] 

Michael Dürig commented on OAK-2736:
------------------------------------

I'm not too happy with the additional Closable. It serves its purpose however. Could we rename {{CloseableExecutor}} to something like {{ExecutorCloser}}? It is not really an executor but rather a closer. 

On a somewhat related note we should probably safeguard the {{createContentRepository}} method such that it throws an {{ISE}} when called more than once. Otherwise multiple repository instances created by the same builder would share their executors.

> Oak instance does not close the executors created upon ContentRepository creation
> ---------------------------------------------------------------------------------
>
>                 Key: OAK-2736
>                 URL: https://issues.apache.org/jira/browse/OAK-2736
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: Chetan Mehrotra
>            Priority: Minor
>             Fix For: 1.3.0
>
>         Attachments: OAK-2736.patch
>
>
> Oak.createContentRepository does not closes the executors it creates upon close. It should close the executor if that is created by itself and not passed by outside
> Also see recent [thread|http://markmail.org/thread/rryydj7vpua5qbub].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)