You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/10/11 23:21:33 UTC
Review Request 62913: Fixed flaky ROOT_DynamicAddDelofCniConfig test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62913/
-----------------------------------------------------------
Review request for mesos, Avinash sridharan, Gaston Kleiman, and Vinod Kone.
Bugs: MESOS-7511
https://issues.apache.org/jira/browse/MESOS-7511
Repository: mesos
Description
-------
Due to clock manipulation, a TASK_RUNNING status update could have
been resent by the status update manager, triggering an expectation
failure.
Diffs
-----
src/tests/containerizer/cni_isolator_tests.cpp 636695f368d1c8acd9ed4ccfd1a449f375af8282
Diff: https://reviews.apache.org/r/62913/diff/1/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 62913: Fixed flaky ROOT_DynamicAddDelofCniConfig
test.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62913/#review187715
-----------------------------------------------------------
Ship it!
Ship It!
- Avinash sridharan
On Oct. 11, 2017, 11:21 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62913/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2017, 11:21 p.m.)
>
>
> Review request for mesos, Avinash sridharan, Gaston Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-7511
> https://issues.apache.org/jira/browse/MESOS-7511
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Due to clock manipulation, a TASK_RUNNING status update could have
> been resent by the status update manager, triggering an expectation
> failure.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cni_isolator_tests.cpp 636695f368d1c8acd9ed4ccfd1a449f375af8282
>
>
> Diff: https://reviews.apache.org/r/62913/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 62913: Fixed flaky ROOT_DynamicAddDelofCniConfig
test.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62913/#review187739
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 62913`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62913
Relevant logs:
- [apply-review-62913-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62913/logs/apply-review-62913-stdout.log):
```
error: patch failed: src/tests/containerizer/cni_isolator_tests.cpp:857
error: src/tests/containerizer/cni_isolator_tests.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On Oct. 11, 2017, 11:21 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62913/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2017, 11:21 p.m.)
>
>
> Review request for mesos, Avinash sridharan, Gaston Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-7511
> https://issues.apache.org/jira/browse/MESOS-7511
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Due to clock manipulation, a TASK_RUNNING status update could have
> been resent by the status update manager, triggering an expectation
> failure.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cni_isolator_tests.cpp 636695f368d1c8acd9ed4ccfd1a449f375af8282
>
>
> Diff: https://reviews.apache.org/r/62913/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 62913: Fixed flaky ROOT_DynamicAddDelofCniConfig
test.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62913/#review187722
-----------------------------------------------------------
Ship it!
Ship It!
- Gaston Kleiman
On Oct. 11, 2017, 4:21 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62913/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2017, 4:21 p.m.)
>
>
> Review request for mesos, Avinash sridharan, Gaston Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-7511
> https://issues.apache.org/jira/browse/MESOS-7511
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Due to clock manipulation, a TASK_RUNNING status update could have
> been resent by the status update manager, triggering an expectation
> failure.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cni_isolator_tests.cpp 636695f368d1c8acd9ed4ccfd1a449f375af8282
>
>
> Diff: https://reviews.apache.org/r/62913/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>