[GitHub] [cordova-plugin-contacts] ihappycoder opened a new pull request #214: Updated windows ContactProxy.js

[GitBox <gi...@apache.org>]

ihappycoder opened a new pull request #214: Updated windows ContactProxy.js
URL: https://github.com/apache/cordova-plugin-contacts/pull/214
 
 
   ### Platforms affected
   
   Windows
   
   ### Motivation and Context
   
   When on windows user decline "Permissions request" prompt, the app immediately crashes since `contactStoreRequest` callback argument is `null`, so lib throws an error which can't be handled from an app level. Every next app open end up with crash too, until the user manually allow contacts permission for the app
   
   
   
   ### Description
   
   Added simple `if` which checks if `contactStoreRequest` callback argument is not `null`
   
   
   ### Testing
   
   Tested on Windows 10 using VS debug feature, the app doesn't crash anymore
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org