You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2024/09/10 16:36:00 UTC
[jira] [Commented] (SOLR-17382) CLI: Deprecate addlopts in RunExampleTool.java
[ https://issues.apache.org/jira/browse/SOLR-17382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880717#comment-17880717 ]
ASF subversion and git services commented on SOLR-17382:
--------------------------------------------------------
Commit 53c0c3c88cb29e2a3b9ffbf5566fe39ff986b12f in solr's branch refs/heads/main from Eric Pugh
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=53c0c3c88cb ]
SOLR-17382: remove -a and use full name for addlopts --additional-options (#2684)
* move -a and -addlopts to deprecated and use --jvm-opts for long format.
* this option is only called by scripts, its not called by end users, so we don't need deprecation in RunExampleTool
> CLI: Deprecate addlopts in RunExampleTool.java
> ----------------------------------------------
>
> Key: SOLR-17382
> URL: https://issues.apache.org/jira/browse/SOLR-17382
> Project: Solr
> Issue Type: Sub-task
> Reporter: Christos Malliaridis
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> [RunExampleTool.java|https://github.com/apache/solr/blob/661b1dac2284ab556573605ae81a4951a5703c49/solr/core/src/java/org/apache/solr/cli/RunExampleTool.java#L190] uses "\-\-addlopts" for {_}additional options{_}, which should be deprecated and replaced with "\-\-additional-options" to follow the naming conventions for long arguments.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org