[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #6361: Add flags to control TLS options for TV Riak util

[GitBox <gi...@apache.org>]

rawlinp commented on a change in pull request #6361:
URL: https://github.com/apache/trafficcontrol/pull/6361#discussion_r752824395



##########
File path: docs/source/tools/traffic_vault_util.rst
##########
@@ -69,4 +69,12 @@ Usage
 
 	.. warning:: Although this flag is optional, the utility will not work without it. It will try, but it will fail\ [1]_.
 
+.. option:: --skip_tls
+
+	An optional flag which, if given, specifies whether to utilize TLS certificate checks when establishing a connection. Defaults to false.
+
+.. option:: --server_name

Review comment:
       Is this option really necessary? I.e. if we pass a hostname using `--vault_ip` (as the help text seems to indicate is ok), requiring this `--server_name` option seems redundant.

##########
File path: docs/source/tools/traffic_vault_util.rst
##########
@@ -28,7 +28,7 @@ The ``traffic_vault_util`` tool - located at :file:`tools/traffic_vault_util.go`
 
 Usage
 =====
-``traffic_vault_util [--dry_run] --vault_ip IP --vault_action ACTION [--vault_user USER] [--vault_password PASSWD] [--vault_port PORT]``
+``traffic_vault_util [--dry_run] --vault_ip IP --vault_action ACTION [--vault_user USER] [--vault_password PASSWD] [--vault_port PORT] [--skip_tls] [--server_name SERVER_NAME]``

Review comment:
       nit: in most places we just call this `--insecure` instead of `--skip_tls`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org