You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "Leishunyu (GitHub)" <gi...@apache.org> on 2018/12/07 04:31:49 UTC

[GitHub] [incubator-dubbo] Leishunyu commented on issue #2831: 修改jdk不兼容问题

> Hi, I would suggest a new class called `AbstractRouter` to wrap the common logic.
> I see there are common attributes e.g. url, priority in `ConditionRouter`, `TagRouter`, and `ScriptRouter`, we need a base class for all the common logic.
> 
> For example, we can put `getPriority()` to `AbstractRouter`
Hey, your suggestion has been modified. If you have time, you can check it out. UT will also take time to make up.


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2831 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org