You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/07/08 22:17:00 UTC

[GitHub] [hadoop-ozone] avijayanhwx opened a new pull request #1179: HDDS-3765. Fluentd writing to secure Ozone S3 API fails with 500 Error.

avijayanhwx opened a new pull request #1179:
URL: https://github.com/apache/hadoop-ozone/pull/1179


   ## What changes were proposed in this pull request?
   While writing to secure Ozone s3 gateway, fluentd fails with 500 Error. This happens when there are extra slashes in the requested object path. (More details are in the JIRA)
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-3765
   
   ## How was this patch tested?
   Manually tested with fluentd s3 plugin.
   Added acceptance tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] prasanthj commented on a change in pull request #1179: HDDS-3765. Fluentd writing to secure Ozone S3 API fails with 500 Error.

Posted by GitBox <gi...@apache.org>.
prasanthj commented on a change in pull request #1179:
URL: https://github.com/apache/hadoop-ozone/pull/1179#discussion_r451927312



##########
File path: hadoop-ozone/dist/src/main/smoketest/security/ozone-secure-s3.robot
##########
@@ -38,6 +40,16 @@ Secure S3 test Success
     ${output} =         Execute          aws s3api --endpoint-url ${ENDPOINT_URL} list-buckets
                         Should contain   ${output}         bucket-test123
 
+Secure S3 put-object test
+    ${testFilePath} =       Set Variable            ${TEMPDIR}/${TEST_FILE}
+                            Copy File               ${TEST_FILE}            ${testFilePath}
+    ${output} =             Execute                 aws s3api --endpoint ${ENDPOINT_URL} put-object --bucket=bucket-test123 --key=tmp1/tmp2/NOTICE.txt --body=${testFilePath}
+    ${output} =             Execute                 aws s3api --endpoint ${ENDPOINT_URL} list-objects --bucket=bucket-test123
+                            Should contain   ${output}         tmp1/tmp2/NOTICE.txt
+    ${output} =             Execute                 aws s3api --endpoint ${ENDPOINT_URL} put-object --bucket=bucket-test123 --key=tmp3//tmp4/NOTICE.txt --body=${testFilePath}

Review comment:
       should we add a test for key with leading '/' as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1179: HDDS-3765. Fluentd writing to secure Ozone S3 API fails with 500 Error.

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #1179:
URL: https://github.com/apache/hadoop-ozone/pull/1179#issuecomment-658304243


   Working with @bharatviswa504 to hash out details in another related JIRA (HDDS-3955). Based on what is decided, this PR may have some changes. Hoping to get this to a resolution in the next few days.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1179: HDDS-3765. Fluentd writing to secure Ozone S3 API fails with 500 Error.

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #1179:
URL: https://github.com/apache/hadoop-ozone/pull/1179#issuecomment-658905716


   In HDDS-3955 we are adding new logic that "normalizes" the key when intermediate directories need to be created on createKey API. This fix is good to go now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] avijayanhwx merged pull request #1179: HDDS-3765. Fluentd writing to secure Ozone S3 API fails with 500 Error.

Posted by GitBox <gi...@apache.org>.
avijayanhwx merged pull request #1179:
URL: https://github.com/apache/hadoop-ozone/pull/1179


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1179: HDDS-3765. Fluentd writing to secure Ozone S3 API fails with 500 Error.

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #1179:
URL: https://github.com/apache/hadoop-ozone/pull/1179#issuecomment-658913179


   Thanks for the review @bharatviswa504.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org