You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by nickva <gi...@git.apache.org> on 2016/08/15 07:00:02 UTC
[GitHub] couchdb-couch-replicator pull request #45: Fix replicator manager `stop` cha...
GitHub user nickva opened a pull request:
https://github.com/apache/couchdb-couch-replicator/pull/45
Fix replicator manager `stop` change feed callback
```
changes_reader_cb({stop, EndSeq, _Pending}, ...) ->
...
```
at one point used to handle changes from `fabric:changes`. It was later
optimized to use shard change feeds, but shard change feed callbacks don't get
pending info with the `stop` message.
As a result replicator manager would always rescan all the changes in a shard
on any new change.
For reference, where `couch_changes.erl` calls the callback:
https://github.com/apache/couchdb-couch/blob/master/src/couch_changes.erl#L654
Jira: COUCHDB-3104
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/couchdb-couch-replicator 3104-fix-replicator-manager-changes-feed-checkpoint
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch-replicator/pull/45.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #45
----
commit 40a087630b9b6688fe2db87f1e8adc7972c4a0c9
Author: Nick Vatamaniuc <va...@gmail.com>
Date: 2016-08-15T06:50:56Z
Fix replicator manager `stop` change feed callback
```
changes_reader_cb({stop, EndSeq, _Pending}, ...) ->
...
```
at one point used to handle changes from `fabric:changes`. It was later
optimized to use shard change feeds, but shard change feed callbacks don't get
pending info with the `stop` message.
As a result replicator manager would always rescan all the changes in a shard
on any new change.
For reference, where `couch_changes.erl` calls the callback:
https://github.com/apache/couchdb-couch/blob/master/src/couch_changes.erl#L654
Jira: COUCHDB-3104
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...
Posted by nickva <gi...@git.apache.org>.
Github user nickva commented on the issue:
https://github.com/apache/couchdb-couch-replicator/pull/45
@kxepal all green again
wondering if there are other small chunks of code we never ran before because of this and those might have bugs hidden too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator pull request #45: Fix replicator manager `stop` cha...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch-replicator/pull/45
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the issue:
https://github.com/apache/couchdb-couch-replicator/pull/45
Our tests in sad state yeah /: But good that they are green now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the issue:
https://github.com/apache/couchdb-couch-replicator/pull/45
+1. But failed tests worries me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...
Posted by nickva <gi...@git.apache.org>.
Github user nickva commented on the issue:
https://github.com/apache/couchdb-couch-replicator/pull/45
@davisp @rnewson this was a fun one to discover
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the issue:
https://github.com/apache/couchdb-couch-replicator/pull/45
@nickva Good. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-couch-replicator/pull/45
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...
Posted by nickva <gi...@git.apache.org>.
Github user nickva commented on the issue:
https://github.com/apache/couchdb-couch-replicator/pull/45
@kxepal I have a fix, fixing this bug revealed another one apparently
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator issue #45: Fix replicator manager `stop` change fee...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-couch-replicator/pull/45
nice catch, reviewing now and should land in RC5 this Thursday if we're good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---