You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2017/05/09 19:12:48 UTC
Review Request 59106: GEODE-2898 A non-responsive SSL client can
block a server's "acceptor" thread
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59106/
-----------------------------------------------------------
Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
Bugs: GEODE-2898
https://issues.apache.org/jira/browse/GEODE-2898
Repository: geode
Description
-------
This moves the SSL handshake from the acceptor thread to the handshake thread and adds a unit test.
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java ed294722db4784f1e9fe895d9f00dd6e4521d5d6
geode-core/src/test/java/org/apache/geode/cache/client/internal/CacheServerSSLConnectionDUnitTest.java 3597152a25de7c2fdc87dfb9ec0e5613b7ec327c
Diff: https://reviews.apache.org/r/59106/diff/1/
Testing
-------
TDD - the test failed with a timeout exception but now passes with the supplied fix.
precheckin testing is underway
Thanks,
Bruce Schuchardt
Re: Review Request 59106: GEODE-2898 A non-responsive SSL client can
block a server's "acceptor" thread
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59106/#review174363
-----------------------------------------------------------
Ship it!
Ship It!
- Udo Kohlmeyer
On May 9, 2017, 7:12 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59106/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 7:12 p.m.)
>
>
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
>
>
> Bugs: GEODE-2898
> https://issues.apache.org/jira/browse/GEODE-2898
>
>
> Repository: geode
>
>
> Description
> -------
>
> This moves the SSL handshake from the acceptor thread to the handshake thread and adds a unit test.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java ed294722db4784f1e9fe895d9f00dd6e4521d5d6
> geode-core/src/test/java/org/apache/geode/cache/client/internal/CacheServerSSLConnectionDUnitTest.java 3597152a25de7c2fdc87dfb9ec0e5613b7ec327c
>
>
> Diff: https://reviews.apache.org/r/59106/diff/1/
>
>
> Testing
> -------
>
> TDD - the test failed with a timeout exception but now passes with the supplied fix.
> precheckin testing is underway
>
>
> Thanks,
>
> Bruce Schuchardt
>
>