You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/23 14:09:00 UTC

[jira] [Commented] (METRON-1570) Downgrade Solr version to match HDP Search

    [ https://issues.apache.org/jira/browse/METRON-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487310#comment-16487310 ] 

ASF GitHub Bot commented on METRON-1570:
----------------------------------------

GitHub user merrimanr opened a pull request:

    https://github.com/apache/metron/pull/1027

    METRON-1570: Downgrade Solr version to match HDP Search

    ## Contributor Comments
    This PR downgrades our Solr version from 6.6.2 to 5.5.4.  The purpose of this change is to catch any incompatibilities with 5.5.4 at compile time rather than at runtime when using Solr 5.5.4.  In theory Solr client code compiled with 5.5.4 should work with 6.6.2.
    
    All changes were fairly minor.  A summary includes:
    
    - disabled Solr auto-configuration in REST
    - changed Solr client instantiation to be compatible with 5.5.4
    - changed Solr collection listing call to be compatible with 5.5.4
    - changed Kerberos configuration to be compatible with 5.5.4
    - updated the in-memory SolrComponent to be compatible with 5.5.4
    
    I tested this in full dev with HDP Search 2.2 (Solr 5.5.4) and could not find any issues.  I also enabled Kerberos and everything worked as expected.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merrimanr/incubator-metron METRON-1570

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1027.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1027
    
----
commit 267d645b3b3da6585fbe8251bf54d47656aaff21
Author: merrimanr <me...@...>
Date:   2018-05-22T20:38:09Z

    initial commit

----


> Downgrade Solr version to match HDP Search
> ------------------------------------------
>
>                 Key: METRON-1570
>                 URL: https://issues.apache.org/jira/browse/METRON-1570
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Ryan Merriman
>            Priority: Major
>
> We should be building and testing with the same version as HDP Search (5.5.4). We need to bump our Maven version down to 5.5.4, make any necessary adjustments in our Solr code and integration/unit tests, and verify everything still works in full dev including Kerberos.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)