You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2005/07/15 15:49:58 UTC

[Bug 4481] New: if ($@) { dbg constructs *should* report the value of $@

http://bugzilla.spamassassin.org/show_bug.cgi?id=4481

           Summary: if ($@) {  dbg constructs *should* report the value of
                    $@
           Product: Spamassassin
           Version: 3.0.3
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Libraries
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: bugzilla@johnbokma.com


When tracking problems with DNS, I found:
if ($@) {
    dbg ("NS lookup failed horribly, perhaps bad resolv.conf setting?");

(line 1056: Mail::SpamAssassin::Dns )

of course it's silly *not* to report the value of $@ which contains very
valuable information: like *why* the lookup failed...

I found more of those constructs...



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4481] if ($@) { dbg constructs *should* report the value of $@

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4481





------- Additional Comments From jm@jmason.org  2007-04-17 12:58 -------
Created an attachment (id=3907)
 --> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3907&action=view)
fix

here's the remaining cases where $@ is used without logging it afterwards -- I
haven't applied it yet.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4481] if ($@) { dbg constructs *should* report the value of $@

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4481


jm@jmason.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|triage                      |
  Status Whiteboard|                            |ready for commit






------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4481] if ($@) { dbg constructs *should* report the value of $@

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4481


Bob@Menschel.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |triage




------- Additional Comments From Bob@Menschel.net  2005-07-16 00:25 -------
Triage: John, given that the devs are busy right now working on the last of the
"important" fixes before 3.1.0, and your good suggestion applies only to debug
messages, it'd be a big help if you could submit patches, or at least diffs for
the various items you find. (If diffs, I can probably put together the patches.)
By submitting patches in this format, the devs can drop them into place,
validate them, and get them into 3.1.0; without patches that's unlikely to
happen at this point. 



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4481] if ($@) { dbg constructs *should* report the value of $@

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4481


jm@jmason.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From jm@jmason.org  2007-04-20 05:31 -------
applied.

: jm 60...; svn commit -m 'bug 4481: always report $@ error messages where
appropriate'
Sending        lib/Mail/SpamAssassin/Conf/LDAP.pm
Sending        lib/Mail/SpamAssassin/Dns.pm
Sending        lib/Mail/SpamAssassin/Logger.pm
Sending        lib/Mail/SpamAssassin/Plugin/RelayCountry.pm
Sending        lib/Mail/SpamAssassin/Plugin/SPF.pm
Sending        spamd/spamd.raw
Transmitting file data ......
Committed revision 530769.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4481] if ($@) { dbg constructs *should* report the value of $@

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4481


jm@jmason.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |3.2.0




------- Additional Comments From jm@jmason.org  2007-04-16 05:34 -------
aim at 3.2.x, for a check



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.