[GitHub] [arrow] amol- edited a comment on pull request #10162: ARROW-12506: [Python] Improve modularity of pyarrow codebase: _ipc module

[GitBox <gi...@apache.org>]

amol- edited a comment on pull request #10162:
URL: https://github.com/apache/arrow/pull/10162#issuecomment-831834231


   > Can you give some details on what's the backwards-compatibility story is here?
   > 
   > I think there are two aspects: python-level and cython-level.
   > In cython, for people doing `from pyarrow.lib cimport RecordBatchReader`, this will stop working?
   > In python, if you accessed the IPC APIs from `pyarrow.lib`, this will also stop working (although I think this is less of a concern, as it was clearly documented otherwise)
   
   I retained compatibility with `pyarrow.ipc` module, so doing `from pyarrow.ipc import RecordBatchReader` will continue to work. While `from pyarrow.lib import RecordBatchReader` as you mentioned will stop working.
   
   I personally think that classes should have one and only one clear owning module, and that seemed to be `ipc` in this case. In general I feel that `lib` is something internal (apart for the explicitly documented things that @pitrou mentioned) and it smells fragile on long term to spread the usage of internals from third parties.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org