You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/07/09 02:39:20 UTC
[GitHub] [phoenix] virajjasani commented on a change in pull request #530:
PHOENIX-5382 : Improved performance with Bulk operations over iterations
virajjasani commented on a change in pull request #530: PHOENIX-5382 : Improved performance with Bulk operations over iterations
URL: https://github.com/apache/phoenix/pull/530#discussion_r301374913
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/util/Closeables.java
##########
@@ -136,9 +137,7 @@ public String getMessage() {
0);
frames.add(header);
- for (StackTraceElement ste : exception.getStackTrace()) {
- frames.add(ste);
- }
+ Collections.addAll(frames, exception.getStackTrace());
Review comment:
@ChinmaySKulkarni Thanks for PR review. Initially thought of doing this change but came across this: https://stackoverflow.com/questions/3343766/why-is-collections-addall-supposed-to-be-faster-than-c-addall
Please let me know if this looks good to you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services