You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/08/26 21:28:31 UTC

[GitHub] [trafficserver] bryancall commented on a change in pull request #7138: remove useless shortopt

bryancall commented on a change in pull request #7138:
URL: https://github.com/apache/trafficserver/pull/7138#discussion_r477599900



##########
File path: plugins/cache_promote/configs.cc
##########
@@ -48,7 +48,7 @@ bool
 PromotionConfig::factory(int argc, char *argv[])
 {
   while (true) {
-    int opt = getopt_long(argc, (char *const *)argv, "psbhe", longopt, nullptr);

Review comment:
       The short options value is needed if you want to allow sort options.
   
   However, the short options are not documented:
   https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/cache_promote.en.html?highlight=promotion




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org