You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Eric Evans (JIRA)" <ji...@apache.org> on 2009/04/18 23:10:14 UTC

[jira] Created: (THRIFT-461) generate thrift code when running test suite

generate thrift code when running test suite
--------------------------------------------

                 Key: THRIFT-461
                 URL: https://issues.apache.org/jira/browse/THRIFT-461
             Project: Thrift
          Issue Type: Bug
          Components: Library (Perl)
            Reporter: Eric Evans


It should be possible to build the architecture independent parts of thrift separately from the architecture dependent ones. This isn't currently possible because building the perl library causes the thrift compiler to be run in preparation of the test suite, which in turn causes the build to fail if the compiler has not yet been built.

The attached patch causes code generation to occur when the test suite is run (in the check-local target).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (THRIFT-461) generate thrift code when running test suite

Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

T Jake Luciani resolved THRIFT-461.
-----------------------------------

    Resolution: Fixed
      Assignee: Eric Evans  (was: T Jake Luciani)

> generate thrift code when running test suite
> --------------------------------------------
>
>                 Key: THRIFT-461
>                 URL: https://issues.apache.org/jira/browse/THRIFT-461
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Perl)
>            Reporter: Eric Evans
>            Assignee: Eric Evans
>         Attachments: 0001-generate-thrift-code-when-running-test-suite.patch
>
>
> It should be possible to build the architecture independent parts of thrift separately from the architecture dependent ones. This isn't currently possible because building the perl library causes the thrift compiler to be run in preparation of the test suite, which in turn causes the build to fail if the compiler has not yet been built.
> The attached patch causes code generation to occur when the test suite is run (in the check-local target).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-461) generate thrift code when running test suite

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708620#action_12708620 ] 

David Reiss commented on THRIFT-461:
------------------------------------

This prevented some of the files under test from being included in release tarballs.  I believe I have fixed that problem without causing the issue described here, but if you guys could check the latest patch in THRIFT-373, that would be great.

> generate thrift code when running test suite
> --------------------------------------------
>
>                 Key: THRIFT-461
>                 URL: https://issues.apache.org/jira/browse/THRIFT-461
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Perl)
>            Reporter: Eric Evans
>            Assignee: Eric Evans
>         Attachments: 0001-generate-thrift-code-when-running-test-suite.patch
>
>
> It should be possible to build the architecture independent parts of thrift separately from the architecture dependent ones. This isn't currently possible because building the perl library causes the thrift compiler to be run in preparation of the test suite, which in turn causes the build to fail if the compiler has not yet been built.
> The attached patch causes code generation to occur when the test suite is run (in the check-local target).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (THRIFT-461) generate thrift code when running test suite

Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

T Jake Luciani reassigned THRIFT-461:
-------------------------------------

    Assignee: T Jake Luciani

> generate thrift code when running test suite
> --------------------------------------------
>
>                 Key: THRIFT-461
>                 URL: https://issues.apache.org/jira/browse/THRIFT-461
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Perl)
>            Reporter: Eric Evans
>            Assignee: T Jake Luciani
>         Attachments: 0001-generate-thrift-code-when-running-test-suite.patch
>
>
> It should be possible to build the architecture independent parts of thrift separately from the architecture dependent ones. This isn't currently possible because building the perl library causes the thrift compiler to be run in preparation of the test suite, which in turn causes the build to fail if the compiler has not yet been built.
> The attached patch causes code generation to occur when the test suite is run (in the check-local target).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-461) generate thrift code when running test suite

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708969#action_12708969 ] 

Eric Evans commented on THRIFT-461:
-----------------------------------

Yup. It's still good.

> generate thrift code when running test suite
> --------------------------------------------
>
>                 Key: THRIFT-461
>                 URL: https://issues.apache.org/jira/browse/THRIFT-461
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Perl)
>            Reporter: Eric Evans
>            Assignee: Eric Evans
>         Attachments: 0001-generate-thrift-code-when-running-test-suite.patch
>
>
> It should be possible to build the architecture independent parts of thrift separately from the architecture dependent ones. This isn't currently possible because building the perl library causes the thrift compiler to be run in preparation of the test suite, which in turn causes the build to fail if the compiler has not yet been built.
> The attached patch causes code generation to occur when the test suite is run (in the check-local target).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-461) generate thrift code when running test suite

Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700631#action_12700631 ] 

T Jake Luciani commented on THRIFT-461:
---------------------------------------

committed, thanks.

> generate thrift code when running test suite
> --------------------------------------------
>
>                 Key: THRIFT-461
>                 URL: https://issues.apache.org/jira/browse/THRIFT-461
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Perl)
>            Reporter: Eric Evans
>            Assignee: T Jake Luciani
>         Attachments: 0001-generate-thrift-code-when-running-test-suite.patch
>
>
> It should be possible to build the architecture independent parts of thrift separately from the architecture dependent ones. This isn't currently possible because building the perl library causes the thrift compiler to be run in preparation of the test suite, which in turn causes the build to fail if the compiler has not yet been built.
> The attached patch causes code generation to occur when the test suite is run (in the check-local target).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-461) generate thrift code when running test suite

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Evans updated THRIFT-461:
------------------------------

    Attachment: 0001-generate-thrift-code-when-running-test-suite.patch

> generate thrift code when running test suite
> --------------------------------------------
>
>                 Key: THRIFT-461
>                 URL: https://issues.apache.org/jira/browse/THRIFT-461
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Perl)
>            Reporter: Eric Evans
>         Attachments: 0001-generate-thrift-code-when-running-test-suite.patch
>
>
> It should be possible to build the architecture independent parts of thrift separately from the architecture dependent ones. This isn't currently possible because building the perl library causes the thrift compiler to be run in preparation of the test suite, which in turn causes the build to fail if the compiler has not yet been built.
> The attached patch causes code generation to occur when the test suite is run (in the check-local target).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.