Re: [PR] fix(datasets): isolate filter state to fix concurrent /dataset race [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #39685:
URL: https://github.com/apache/superset/pull/39685#issuecomment-4503279092

   Done in 862b193d. Lifted `_handle_filters_args` from `DatasetRestApi` to `BaseSupersetModelRestApi` (superset/views/base_api.py), so the request-scoped fix now applies to every subclass — ChartRestApi, DashboardRestApi, SavedQueryRestApi, QueryRestApi, DatabaseRestApi, etc. — not just datasets.
   
   The override is purely generic (no dataset-specific logic), and a grep confirmed no other superset REST API overrides `_handle_filters_args`, so zero collision risk. Docstring updated to reference the broader scope and cite #33828 for the original dataset-level repro. Test stays in `tests/unit_tests/datasets/api_tests.py` using `DatasetRestApi` as a concrete subclass to exercise the inherited behavior.
   
   Thanks for the catch — this would've been a follow-up that nobody got to.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org