[GitHub] [hive] rbalamohan commented on a diff in pull request #4026: HIVE-27031: Iceberg: Implement Copy-On-Write for Delete Queries.

["rbalamohan (via GitHub)" <gi...@apache.org>]

rbalamohan commented on code in PR #4026:
URL: https://github.com/apache/hive/pull/4026#discussion_r1103473653


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -1153,4 +1155,16 @@ public Map<String, String> getNativeProperties(org.apache.hadoop.hive.ql.metadat
     props.put(InputFormatConfig.PARTITION_SPEC, PartitionSpecParser.toJson(origTable.spec()));
     return props;
   }
+
+  @Override
+  public boolean shouldOverwrite(org.apache.hadoop.hive.ql.metadata.Table mTable, String operationName) {
+    String mode = null;
+    String formatVersion = mTable.getTTable().getParameters().get(TableProperties.FORMAT_VERSION);
+    // As of now only delete mode is supported, for all others return false
+    if ("2".equals(formatVersion) && operationName.equalsIgnoreCase("delete")) {

Review Comment:
   Will update be supported later?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org