You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jmeter.apache.org by ham1 <gi...@git.apache.org> on 2017/01/21 22:30:16 UTC

[GitHub] jmeter pull request #255: Utilised Java 8 (and 7) features to tidy up code

GitHub user ham1 opened a pull request:

    https://github.com/apache/jmeter/pull/255

    Utilised Java 8 (and 7) features to tidy up code

    Used lambdas, method references, multi-catch blocks and `ThreadLocal.withInitial` to improve code readability.
    Also removed unnecessary types.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ham1/jmeter java8

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/255.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #255
    
----
commit 7231600c525be98624e611d488b2f48f9a978a12
Author: Graham Russell <gr...@ham1.co.uk>
Date:   2017-01-21T09:32:08Z

    Utilized Java 8 (and 7) features to tidy up code

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request #255: Utilised Java 8 (and 7) features to tidy up code

Posted by ham1 <gi...@git.apache.org>.

Github user ham1 closed the pull request at:

    https://github.com/apache/jmeter/pull/255


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #255: Utilised Java 8 (and 7) features to tidy up code

Posted by ham1 <gi...@git.apache.org>.

Github user ham1 commented on the issue:

    https://github.com/apache/jmeter/pull/255
  
    Sorry, updated now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #255: Utilised Java 8 (and 7) features to tidy up code

Posted by FSchumacher <gi...@git.apache.org>.

Github user FSchumacher commented on the issue:

    https://github.com/apache/jmeter/pull/255
  
    Thanks for your contribution.
    
    Looks good, but as usual, I would have liked to see the different cleanups in different commits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #255: Utilised Java 8 (and 7) features to tidy up code

Posted by ham1 <gi...@git.apache.org>.

Github user ham1 commented on the issue:

    https://github.com/apache/jmeter/pull/255
  
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---