You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@opennlp.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/06/04 21:23:00 UTC
[jira] [Commented] (OPENNLP-1370) Update date in NOTICE file
[ https://issues.apache.org/jira/browse/OPENNLP-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17549508#comment-17549508 ]
ASF GitHub Bot commented on OPENNLP-1370:
-----------------------------------------
kumar-abhishek opened a new pull request, #418:
URL: https://github.com/apache/opennlp/pull/418
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
> Update date in NOTICE file
> --------------------------
>
> Key: OPENNLP-1370
> URL: https://issues.apache.org/jira/browse/OPENNLP-1370
> Project: OpenNLP
> Issue Type: Task
> Components: Build, Packaging and Test
> Affects Versions: 1.9.4
> Reporter: Jeff Zemerick
> Priority: Major
>
> Per [~kinow] on the mailing list --
> I downloaded a ZIP from Maven (opennlp-distr-2.0.0-bin.zip) and its NOTICE had 2017. At least in Apache Commons and Jena we try to keep the NOTICE file up to date (I think it's an ASF policy?)
--
This message was sent by Atlassian Jira
(v8.20.7#820007)