You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/09/14 10:52:33 UTC
[GitHub] [dolphinscheduler] LiuBodong opened a new pull request #6207: [DS-6091][standalone] fix StandaloneServer run failed on Windows system
LiuBodong opened a new pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207
## Purpose of the pull request
Fix the bug that StandaloneServer run failed on Windows system.
## Brief change log
* Fix java.nio.file.InvalidPathException in StandaloneServer
The bug's reason is when we call `Class#getProtectionDomain().getCodeSource().getLocation().getPath()` on Windows, JAVA will return a path starts with '/', and then we use `Paths.get(path)` to transform the path, the bug appears.
The solution is use `Paths.get(URL url)` method to transform the path, it will work correctly.
* Fix bug when use "/target/classes" to judge path will always return false.
The bug's reason is use `File#getPath.endsWith("/target/classes")` to judge if the given path is compiled class path. On Windows, the delimiter of path is '\', so the method always returns false.
The solution is use `Paths.endsWith(Path other)` method to judge, it will work correctly.
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] LiuBodong closed pull request #6207: [DS-6091][standalone] Fix DolphinPluginDiscovery load plugin fails on Windows os
Posted by GitBox <gi...@apache.org>.
LiuBodong closed pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] LiuBodong closed pull request #6207: [DS-6091][standalone] Fix DolphinPluginDiscovery load plugin fails on Windows os
Posted by GitBox <gi...@apache.org>.
LiuBodong closed pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on a change in pull request #6207: [DS-6091][standalone] fix StandaloneServer run failed on Windows system
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207#discussion_r708159856
##########
File path: dolphinscheduler-standalone-server/src/main/java/org/apache/dolphinscheduler/server/StandaloneServer.java
##########
@@ -118,13 +123,54 @@ private static void startDatabase() throws IOException, SQLException {
}
private static void setTaskPlugin() {
- final Path taskPluginPath = Paths.get(
- StandaloneServer.class.getProtectionDomain().getCodeSource().getLocation().getPath(),
- "../../../dolphinscheduler-task-plugin/dolphinscheduler-task-shell/pom.xml"
- ).toAbsolutePath();
+
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #6207: [DS-6091][standalone] Fix DolphinPluginDiscovery load plugin fails on Windows os
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207#issuecomment-921427199
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6207&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6207&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6207&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6207&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] LiuBodong commented on pull request #6207: [DS-6091][standalone] fix StandaloneServer run failed on Windows system
Posted by GitBox <gi...@apache.org>.
LiuBodong commented on pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207#issuecomment-921361911
I just revert the modification of StandaloneServer.java, now the pr only contains modification of DolphinPluginDiscovery.java. Please do a code review~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] LiuBodong commented on pull request #6207: [DS-6091][standalone] Fix DolphinPluginDiscovery load plugin fails on Windows os
Posted by GitBox <gi...@apache.org>.
LiuBodong commented on pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207#issuecomment-961586587
already fixed in another pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on a change in pull request #6207: [DS-6091][standalone] fix StandaloneServer run failed on Windows system
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207#discussion_r708159511
##########
File path: dolphinscheduler-standalone-server/src/main/java/org/apache/dolphinscheduler/server/StandaloneServer.java
##########
@@ -71,10 +75,11 @@ public static void main(String[] args) throws Exception {
}
private static void startAlertServer() {
- final Path alertPluginPath = Paths.get(
- StandaloneServer.class.getProtectionDomain().getCodeSource().getLocation().getPath(),
- "../../../dolphinscheduler-alert-plugin/dolphinscheduler-alert-email/pom.xml"
- ).toAbsolutePath();
+
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #6207: [DS-6091][standalone] Fix DolphinPluginDiscovery load plugin fails on Windows os
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207#issuecomment-921662838
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6207&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6207&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6207&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6207&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] LiuBodong commented on pull request #6207: [DS-6091][standalone] Fix DolphinPluginDiscovery load plugin fails on Windows os
Posted by GitBox <gi...@apache.org>.
LiuBodong commented on pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207#issuecomment-961586587
already fixed in another pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] QuakeWang commented on pull request #6207: [DS-6091][standalone] fix StandaloneServer run failed on Windows system
Posted by GitBox <gi...@apache.org>.
QuakeWang commented on pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207#issuecomment-920601808
We have discussed and come up with the following recommendation: This pr retains the changes to DolphinPluginDiscovery. The changes to StandaloneServer are still based on #6101.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #6207: [DS-6091][standalone] fix StandaloneServer run failed on Windows system
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207#issuecomment-919050200
This PR is duplicate with #6101, can you please coordinate with @QuakeWang which PR we should continue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #6207: [DS-6091][standalone] Fix DolphinPluginDiscovery load plugin fails on Windows os
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207#issuecomment-921425261
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/6207?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6207](https://codecov.io/gh/apache/dolphinscheduler/pull/6207?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a129b71) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/a1e447d39969362b5b380b6b802ce47d961bde51?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1e447d) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dolphinscheduler/pull/6207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## dev #6207 +/- ##
============================================
- Coverage 39.07% 39.06% -0.01%
+ Complexity 3250 3249 -1
============================================
Files 638 638
Lines 25266 25267 +1
Branches 2743 2743
============================================
- Hits 9872 9871 -1
- Misses 14516 14517 +1
- Partials 878 879 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/6207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...inscheduler/spi/plugin/DolphinPluginDiscovery.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6207/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc3BpL3BsdWdpbi9Eb2xwaGluUGx1Z2luRGlzY292ZXJ5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6207/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/6207?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/6207?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a1e447d...a129b71](https://codecov.io/gh/apache/dolphinscheduler/pull/6207?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #6207: [DS-6091][standalone] fix StandaloneServer run failed on Windows system
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207#issuecomment-921415529
@LiuBodong please update the PR title and commit message accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] LiuBodong closed pull request #6207: [DS-6091][standalone] Fix DolphinPluginDiscovery load plugin fails on Windows os
Posted by GitBox <gi...@apache.org>.
LiuBodong closed pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] LiuBodong commented on pull request #6207: [DS-6091][standalone] Fix DolphinPluginDiscovery load plugin fails on Windows os
Posted by GitBox <gi...@apache.org>.
LiuBodong commented on pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207#issuecomment-961586587
already fixed in another pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] removed a comment on pull request #6207: [DS-6091][standalone] Fix DolphinPluginDiscovery load plugin fails on Windows os
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207#issuecomment-921427199
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6207&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6207&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6207&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6207&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6207&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] LiuBodong closed pull request #6207: [DS-6091][standalone] Fix DolphinPluginDiscovery load plugin fails on Windows os
Posted by GitBox <gi...@apache.org>.
LiuBodong closed pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] LiuBodong commented on pull request #6207: [DS-6091][standalone] fix StandaloneServer run failed on Windows system
Posted by GitBox <gi...@apache.org>.
LiuBodong commented on pull request #6207:
URL: https://github.com/apache/dolphinscheduler/pull/6207#issuecomment-919602913
>
>
> This PR is duplicate with #6101, can you please coordinate with @QuakeWang which PR we should continue?
I already send an e-mail to @QuakeWang , we will talk later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org