You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/12/07 13:47:03 UTC
[GitHub] [calcite] NobiGo opened a new pull request #2633: [CALCITE-4851] Lots of warnings about Execution optimizations have be…
NobiGo opened a new pull request #2633:
URL: https://github.com/apache/calcite/pull/2633
…en disabled when build CALCITE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] NobiGo commented on a change in pull request #2633: [CALCITE-4851] Lots of warnings about Execution optimizations have be…
Posted by GitBox <gi...@apache.org>.
NobiGo commented on a change in pull request #2633:
URL: https://github.com/apache/calcite/pull/2633#discussion_r764076297
##########
File path: babel/build.gradle.kts
##########
@@ -52,6 +52,14 @@ val javaCCMain by tasks.registering(org.apache.calcite.buildtools.javacc.JavaCCT
packageName.set("org.apache.calcite.sql.parser.babel")
}
+tasks.autostyleJavaCheck {
+ dependsOn(javaCCMain)
+}
+
+tasks.checkstyleMain {
+ dependsOn(javaCCMain)
+}
Review comment:
@vlsi Please help review again. Thanks very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] NobiGo commented on pull request #2633: [CALCITE-4851] Build gives lots of 'Execution optimizations have been disabled' warnings
Posted by GitBox <gi...@apache.org>.
NobiGo commented on pull request #2633:
URL: https://github.com/apache/calcite/pull/2633#issuecomment-988732609
> We do not verify the code style for the generated code, so the dependencies should be `mustRunAfter` rather than `dependsOn`.
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] vlsi commented on a change in pull request #2633: [CALCITE-4851] Lots of warnings about Execution optimizations have be…
Posted by GitBox <gi...@apache.org>.
vlsi commented on a change in pull request #2633:
URL: https://github.com/apache/calcite/pull/2633#discussion_r764018946
##########
File path: babel/build.gradle.kts
##########
@@ -52,6 +52,14 @@ val javaCCMain by tasks.registering(org.apache.calcite.buildtools.javacc.JavaCCT
packageName.set("org.apache.calcite.sql.parser.babel")
}
+tasks.autostyleJavaCheck {
+ dependsOn(javaCCMain)
+}
+
+tasks.checkstyleMain {
+ dependsOn(javaCCMain)
+}
Review comment:
This would break in case `-PskipCheckstyle` or `-PskipAutostyle`.
Something like https://github.com/apache/jmeter/blob/0938f50e15cc62e2de645b823def881364e64b78/src/core/build.gradle.kts#L145-L160 might do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] NobiGo commented on a change in pull request #2633: [CALCITE-4851] Build gives lots of 'Execution optimizations have been disabled' warnings
Posted by GitBox <gi...@apache.org>.
NobiGo commented on a change in pull request #2633:
URL: https://github.com/apache/calcite/pull/2633#discussion_r764784331
##########
File path: babel/build.gradle.kts
##########
@@ -52,6 +52,14 @@ val javaCCMain by tasks.registering(org.apache.calcite.buildtools.javacc.JavaCCT
packageName.set("org.apache.calcite.sql.parser.babel")
}
+tasks.autostyleJavaCheck {
+ dependsOn(javaCCMain)
+}
+
+tasks.checkstyleMain {
+ dependsOn(javaCCMain)
+}
Review comment:
> This would break in case `-PskipCheckstyle` or `-PskipAutostyle`. Something like https://github.com/apache/jmeter/blob/0938f50e15cc62e2de645b823def881364e64b78/src/core/build.gradle.kts#L145-L160 might do.
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] vlsi commented on pull request #2633: [CALCITE-4851] Lots of warnings about Execution optimizations have be…
Posted by GitBox <gi...@apache.org>.
vlsi commented on pull request #2633:
URL: https://github.com/apache/calcite/pull/2633#issuecomment-987948569
We do not verify the code style for the generated code, so the dependencies should be `mustRunAfter` rather than `dependsOn`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] NobiGo merged pull request #2633: [CALCITE-4851] Build gives lots of 'Execution optimizations have been disabled' warnings
Posted by GitBox <gi...@apache.org>.
NobiGo merged pull request #2633:
URL: https://github.com/apache/calcite/pull/2633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org